gh-104232: Fix sys.settrace docs to reflect the reality#110516
Merged
brandtbucher merged 1 commit intopython:mainfrom Oct 18, 2023
Merged
gh-104232: Fix sys.settrace docs to reflect the reality#110516brandtbucher merged 1 commit intopython:mainfrom
sys.settrace docs to reflect the reality#110516brandtbucher merged 1 commit intopython:mainfrom
Conversation
Member
|
Thanks for looking into it (this has always confused me too). |
|
Thanks @gaogaotiantian for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 18, 2023
|
GH-111045 is a backport of this pull request to the 3.11 branch. |
|
Thanks @gaogaotiantian for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 18, 2023
|
GH-111047 is a backport of this pull request to the 3.12 branch. |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


In our current docs, we claim that:
That is not the case, and for as far as we know.
Returning
Nonein the local trace function has no effect and it's already the de facto. There are at least 3 issues about this (#104232, #78980 and #56201) and it should not be that difficult to fix this. Rather than changing the behavior which could potentially break someone's code, we can simply change our docs because we never achieved what we claimed anyway, and people are fine with it.📚 Documentation preview 📚: https://cpython-previews--110516.org.readthedocs.build/