X Tutup
The Wayback Machine - https://web.archive.org/web/20260313052945/https://github.com/python/cpython/pull/109744
Skip to content

Code: Update Donghee Na's name#109744

Merged
hugovk merged 2 commits intopython:mainfrom
hugovk:name-donghee-na-code
Sep 25, 2023
Merged

Code: Update Donghee Na's name#109744
hugovk merged 2 commits intopython:mainfrom
hugovk:name-donghee-na-code

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented Sep 22, 2023

Opened separately from the docs changes in #109743, because we can't backport non-docs things to 3.12 until after 3.12.0 is out on 2023-10-02.

@hugovk hugovk requested a review from corona10 September 22, 2023 14:59
corona10
corona10 reviewed Sep 22, 2023
View reviewed changes
Modules/expat/xmlparse.c Outdated
Copyright (c) 2019-2020 Ben Wagner <bungeman@chromium.org>
Copyright (c) 2019 Vadim Zeitlin <vadim@zeitlins.org>
Copyright (c) 2021 Dong-hee Na <donghee.na@python.org>
Copyright (c) 2021 Donghee Na <donghee.na@python.org>
Copy link
Member

@corona10 corona10 Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's copied from libexpat.
https://github.com/libexpat/libexpat

I am not sure that updating legal name for expat is proper :(

Copy link
Member

@corona10 corona10 Sep 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libexpat/libexpat#754

I sent the PR to the upstream too :)
Let's wait

Copy link
Contributor

@hartwork hartwork Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm positive that (1) we'll have a version of libexpat/libexpat#754 merged upstream shortly and that (2) there will be a release >=2.5.1 this year bringing these changes to CPython "for free" just by upgrading the bundled copy of libexpat.

Copy link
Member Author

@hugovk hugovk Sep 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I'll revert the changes to Modules/expat/ here, and we can wait for the upstream changes to filter through.

corona10
corona10 approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you so much!!

corona10
corona10 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again

@hugovk hugovk merged commit f194165 into python:main Sep 25, 2023
@hugovk hugovk deleted the name-donghee-na-code branch September 25, 2023 15:17
@bedevere-bot
Copy link

bedevere-bot commented Sep 25, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD 3.x has failed when building commit f194165.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1223/builds/216) and take a look at the build logs.
  4. Check if the failure is related to this commit (f194165) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1223/builds/216

Failed tests:

  • test.test_concurrent_futures.test_shutdown

Summary of the results of the build (if available):

==

Click to see traceback logs 
remote: Enumerating objects: 15, done.        
remote: Counting objects:   6% (1/15)        
remote: Counting objects:  13% (2/15)        
remote: Counting objects:  20% (3/15)        
remote: Counting objects:  26% (4/15)        
remote: Counting objects:  33% (5/15)        
remote: Counting objects:  40% (6/15)        
remote: Counting objects:  46% (7/15)        
remote: Counting objects:  53% (8/15)        
remote: Counting objects:  60% (9/15)        
remote: Counting objects:  66% (10/15)        
remote: Counting objects:  73% (11/15)        
remote: Counting objects:  80% (12/15)        
remote: Counting objects:  86% (13/15)        
remote: Counting objects:  93% (14/15)        
remote: Counting objects: 100% (15/15)        
remote: Counting objects: 100% (15/15), done.        
remote: Compressing objects:  50% (1/2)        
remote: Compressing objects: 100% (2/2)        
remote: Compressing objects: 100% (2/2), done.        
remote: Total 8 (delta 7), reused 6 (delta 6), pack-reused 0        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to 'f19416534a546460fdf6a0739b70e44d1950a073'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at f19416534a Code: Update Donghee Na's name (#109744)
Switched to and reset branch 'main'

csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@hugovk @csm10495
Code: Update Donghee Na's name (python#109744)
9045142
@hugovk hugovk added the needs backport to 3.12 only security fixes label Oct 2, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Oct 2, 2023

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 2, 2023
@hugovk @miss-islington
Code: Update Donghee Na's name (pythonGH-109744)
fc999eb 
(cherry picked from commit f194165)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 2, 2023

GH-110225 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 2, 2023
hugovk added a commit that referenced this pull request Oct 2, 2023
@miss-islington @hugovk
[3.12] Code: Update Donghee Na's name (GH-109744) (#110225)
196738f 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@hugovk @Glyphack
Code: Update Donghee Na's name (python#109744)
3c9c5c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes

+1 more reviewer

@hartwork hartwork hartwork left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@hugovk hugovk

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hugovk @bedevere-bot @miss-islington @hartwork @corona10
X Tutup