X Tutup
The Wayback Machine - https://web.archive.org/web/20230807151357/https://github.com/python/cpython/issues/107724
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The callback signature for PY_THROW is inconsistent with the other exception handling callbacks #107724

Open
markshannon opened this issue Aug 7, 2023 · 0 comments
Open

The callback signature for PY_THROW is inconsistent with the other exception handling callbacks #107724

markshannon opened this issue Aug 7, 2023 · 0 comments
Labels
3.12 bugs and security fixes release-blocker type-bug An unexpected behavior, bug, or error

Comments

@markshannon
Copy link
Member

markshannon commented Aug 7, 2023 •
edited

The callbacks for RAISE, RERAISE, EXCEPTION_HANDLED, PY_UNWIND and STOP_ITERATION all take the exception as their third argument.
PY_THROW is the odd one out, but it should be consistent with the others.
PY_THROW is a rare event, so this got overlooked. We should fix it before the next release of 3.12.

Fortunately it is very easy to fix.
@markshannon markshannon added type-bug An unexpected behavior, bug, or error 3.12 bugs and security fixes release-blocker labels Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 bugs and security fixes release-blocker type-bug An unexpected behavior, bug, or error
Projects
Release and Deferred blockers
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@markshannon
X Tutup