X Tutup
The Wayback Machine - https://web.archive.org/web/20220323084010/https://github.com/nodejs/node/pull/37901
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: increase wiggle room for memory in test-worker-resource-limits #37901

Closed
wants to merge 1 commit into from
Closed

test: increase wiggle room for memory in test-worker-resource-limits #37901

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 25, 2021

Fixes: #37844

@nodejs-github-bot nodejs-github-bot added needs-ci test labels Mar 25, 2021
@Trott
Copy link
Member Author

@Trott Trott commented Mar 25, 2021

Fast-track if 20% is enough to fix it on Debug builds?

@Trott Trott requested review from addaleax and danbev Mar 25, 2021
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Mar 25, 2021 •
edited by Trott

CI: https://ci.nodejs.org/job/node-test-pull-request/36957/ ✅

@Trott Trott requested a review from jasnell Mar 25, 2021
@Trott Trott added the flaky-test label Mar 25, 2021
@Trott Trott mentioned this pull request Mar 25, 2021
Closed
@danbev
Copy link
Member

@danbev danbev commented Mar 25, 2021 •
edited

I'll take a look and link and test against OpenSSL 3.0 now ✔️

danbev
danbev approved these changes Mar 25, 2021
View changes
aduh95
aduh95 approved these changes Mar 25, 2021
View changes
danbev added a commit that referenced this issue Mar 25, 2021
@Trott @danbev
test: increase wiggle room for memory in test-worker-resource-limits
498c6b1 
PR-URL: #37901
Fixes: #37844
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danbev
Copy link
Member

@danbev danbev commented Mar 25, 2021

Landed in 498c6b1

@danbev danbev closed this Mar 25, 2021
@aduh95 aduh95 added the fast-track label Mar 25, 2021
ruyadorno added a commit that referenced this issue Mar 29, 2021
@Trott @ruyadorno
test: increase wiggle room for memory in test-worker-resource-limits
796c308 
PR-URL: #37901
Fixes: #37844
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
ruyadorno added a commit that referenced this issue Mar 30, 2021
@Trott @ruyadorno
test: increase wiggle room for memory in test-worker-resource-limits
76ebc4b 
PR-URL: #37901
Fixes: #37844
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Mar 30, 2021
Merged
targos added a commit that referenced this issue May 1, 2021
@Trott @targos
test: increase wiggle room for memory in test-worker-resource-limits
4c5eff9 
PR-URL: #37901
Fixes: #37844
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbev danbev

@aduh95 aduh95

@addaleax addaleax

@jasnell jasnell

Assignees
No one assigned
Labels
fast-track flaky-test needs-ci test
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

investigate flaky test-worker-resource-limits
4 participants
@Trott @nodejs-github-bot @danbev @aduh95
X Tutup