Add a warning message about PyOS_snprintf #95993
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
approved these changes
Oct 7, 2022
|
Thanks @eric-wieser for the PR, and @JelleZijlstra for merging it |
|
GH-98047 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 7, 2022
(cherry picked from commit c7b2204) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
GH-98048 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 7, 2022
(cherry picked from commit c7b2204) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Oct 7, 2022
(cherry picked from commit c7b2204) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Oct 7, 2022
(cherry picked from commit c7b2204) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
mpage
pushed a commit
to mpage/cpython
that referenced
this pull request
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The top google result for "determine sprintf buffer size" is https://stackoverflow.com/a/3923207/102441, which advocates code along the lines of
Unfortunately, this does not work for
PyOS_snprintf, as it includes anassertto ensure the arguments are notNULLand0.This PR simply documents this limitation.