Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Inline AbstractNode into SemanticsNode and Layer #128467
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
github-actions
bot
added
a: accessibility
goderbauer
force-pushed
the
removeAbstractNodeFromSemantics
branch
from
1f939f1
to
56312a9
Compare
goderbauer
force-pushed
the
removeAbstractNodeFromSemantics
branch
from
56312a9
to
c6d4b45
Compare
goderbauer
changed the title
| /// [depth] will still be 2. Whenever a new node is added to the tree or a node | ||
| /// is moved around in the tree, [redepthChild] must be called to re-calculate | ||
| /// the [depth] of the child and its children. | ||
| mixin DepthNode { |
There was a problem hiding this comment.
this is such a small amount of trivial code that i would just inline it into the various class hierarchies that use it.
There was a problem hiding this comment.
Sounds good, inlined it all. Can you take another look?
goderbauer
added
the
autosubmit
The goal is to ultimately remove AbstractNode from the code base.
Next up: Removing it from RenderObject.