X Tutup
The Wayback Machine - https://web.archive.org/web/20250608000505/https://github.com/python/cpython/pull/2799
Skip to content

gh-69057: Add startline and endline attributes to the tokens returned by shlex #2799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-69057: Add startline and endline attributes to the tokens returned by shlex #2799

wants to merge 2 commits into from

Conversation

gareth-rees
Copy link
Contributor

@gareth-rees gareth-rees commented Jul 21, 2017 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Dec 8, 2018
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 20, 2022
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Jul 29, 2022
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Aug 29, 2022
@arhadthedev arhadthedev changed the title bpo-24869: Add startline and endline attributes to the tokens returned by shlex gh-69057: Add startline and endline attributes to the tokens returned by shlex Feb 14, 2023
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Feb 15, 2023
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Mar 18, 2023
@arhadthedev
Copy link
Member

Changing token type from str to Token breaks backward compatibility with existing Python libraries that use shlex and may rely on tokens being comparable with strings. Is there a way to fix it in this PR?

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Apr 14, 2023
@gareth-rees
Copy link
Contributor Author

Changing token type from str to Token breaks backward compatibility with existing Python libraries that use shlex and may rely on tokens being comparable with strings. Is there a way to fix it in this PR?

Token inherits from str so everything will continue to work except for code that does silly stuff like checking type(token) is str instead of isinstance(token, str).

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting core review stale Stale PR or inactive for long period of time. type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gareth-rees @arhadthedev @brettcannon @serhiy-storchaka @the-knights-who-say-ni @ezio-melotti @bedevere-bot
X Tutup