X Tutup
The Wayback Machine - https://web.archive.org/web/20230518065429/https://github.com/nodejs/node/pull/45629
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add cjs_module_lexer_version and base64_version #45629

Merged
merged 1 commit into from May 14, 2023
Merged

src: add cjs_module_lexer_version and base64_version #45629

merged 1 commit into from May 14, 2023
+46 −2

Conversation

MrJithil
Copy link
Contributor

@MrJithil MrJithil commented Nov 26, 2022 •
edited

Ref: #45260

Added version info of cjs_module_lexer and base64_version

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Nov 26, 2022
@MrJithil MrJithil changed the title build: add cjs_module_lexer_version build: add cjs_module_lexer_version and base64_version Nov 26, 2022
@MrJithil MrJithil force-pushed the addCjsModuleLexerVersion branch 6 times, most recently from f5d3e71 to 65d9864 Compare November 26, 2022 05:00
@MrJithil MrJithil changed the title build: add cjs_module_lexer_version and base64_version src: add cjs_module_lexer_version and base64_version Nov 26, 2022
@MrJithil MrJithil closed this Nov 27, 2022
@MrJithil MrJithil reopened this Nov 27, 2022
@MrJithil MrJithil mentioned this pull request Nov 27, 2022
Closed
6 tasks
@MrJithil
Copy link
Contributor Author

Can we add process label if I am not wrong.

@MrJithil MrJithil force-pushed the addCjsModuleLexerVersion branch 2 times, most recently from 3fff7bc to 03da04e Compare November 29, 2022 09:05
@MrJithil MrJithil closed this Nov 29, 2022
@MrJithil MrJithil reopened this Nov 29, 2022
@MrJithil MrJithil closed this Dec 1, 2022
@MrJithil MrJithil reopened this Dec 1, 2022
@MrJithil MrJithil closed this Dec 2, 2022
@MrJithil MrJithil reopened this Dec 2, 2022
@MrJithil
Copy link
Contributor Author

Resolved conflicts

@MrJithil MrJithil requested a review from RaisinTen May 13, 2023 02:43
RaisinTen
RaisinTen approved these changes May 13, 2023
View reviewed changes
Copy link
Member

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
aduh95
aduh95 reviewed May 13, 2023
View reviewed changes
tools/dep_updaters/update-base64.sh Outdated Show resolved Hide resolved
tools/dep_updaters/update-base64.sh Outdated Show resolved Hide resolved
tools/dep_updaters/update-cjs-module-lexer.sh Show resolved Hide resolved
@aduh95 aduh95 dismissed their stale review May 13, 2023 11:47

My requested changes have been addressed, my remaining comments are non-blocking

@github-actions github-actions bot mentioned this pull request May 14, 2023
Open
14 tasks
@MrJithil
src: add cjs_module_lexer_version base64_version
8af37e7 
src: add cjs_module_lexer_version base64_version
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 14, 2023
@nodejs-github-bot
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/51784/

@RaisinTen RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 14, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 14, 2023
@nodejs-github-bot nodejs-github-bot merged commit abb1c45 into nodejs:main May 14, 2023
55 checks passed
@nodejs-github-bot
Copy link
Contributor

Landed in abb1c45

targos pushed a commit that referenced this pull request May 14, 2023
@MrJithil @targos
src: add cjs_module_lexer_version base64_version
dd8ed39 
src: add cjs_module_lexer_version base64_version
PR-URL: #45629
Refs: #45260
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@github-actions github-actions bot mentioned this pull request May 15, 2023
Open
17 tasks
@targos targos added the semver-minor PRs that contain new features and should be released in the next minor version. label May 15, 2023
@targos targos mentioned this pull request May 15, 2023
Closed
targos pushed a commit that referenced this pull request May 15, 2023
@MrJithil @targos
src: add cjs_module_lexer_version base64_version
1aec718 
src: add cjs_module_lexer_version base64_version
PR-URL: #45629
Refs: #45260
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request May 15, 2023
Merged
@amul69906995 amul69906995 mentioned this pull request May 15, 2023
Closed
This was referenced May 16, 2023
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@JungMinu JungMinu JungMinu approved these changes

@aduh95 aduh95 aduh95 approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. semver-minor PRs that contain new features and should be released in the next minor version. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@MrJithil @nodejs-github-bot @aduh95 @debadree25 @jasnell @JungMinu @RaisinTen @panva @targos
X Tutup