Preserve the Exit Code of Running the Tests#166
Merged
ericsnowcurrently merged 6 commits intopython:mainfrom Mar 28, 2022
Merged
Preserve the Exit Code of Running the Tests#166ericsnowcurrently merged 6 commits intopython:mainfrom
ericsnowcurrently merged 6 commits intopython:mainfrom
Conversation
Member
Author
|
We will deal with failures separately. |
Member
|
It appears that this commit broke (or exposed a failure in?) our PyPy CI job. Looks like venv creation isn't working right? |
Member
Author
|
Yeah, it is a pre-existing failure. See #167. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have been ignoring the exit code of the subprocess in runtests.py.