X Tutup
The Wayback Machine - https://web.archive.org/web/20230429005354/https://github.com/python/cpython/pull/103940
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-94673: Ensure Builtin Static Types are Readied Properly #103940

Merged
merged 6 commits into from Apr 27, 2023
Merged

gh-94673: Ensure Builtin Static Types are Readied Properly #103940

merged 6 commits into from Apr 27, 2023

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Apr 27, 2023 •
edited by bedevere-bot

There were cases where we do unnecessary work for builtin static types. This also simplifies some work necessary for a per-interpreter GIL.

@bedevere-bot bedevere-bot mentioned this pull request Apr 27, 2023
Closed
@ericsnowcurrently ericsnowcurrently merged commit d2e2e53 into python:main Apr 27, 2023
16 checks passed
@ericsnowcurrently ericsnowcurrently deleted the ensure-builtin-static-type-ready branch April 27, 2023 22:19
@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 27, 2023
Merged
ericsnowcurrently added a commit that referenced this pull request Apr 28, 2023
@ericsnowcurrently
gh-94673: Fix _PyTypes_InitTypes() and get_type_attr_as_size() (gh-10…
424a785 
…3961)

This change has two small parts:

1. a follow-up to gh-103940 with one case I missed
2. adding a missing return that I noticed while working on related code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ericsnowcurrently @bedevere-bot
X Tutup