gh-102927: xmlrpc: allow 64bit and bigintegers#102930
Closed
Conversation
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
1 similar comment
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
arhadthedev
added
the
stdlib
ghost
changed the title
ghost
requested review from
a team,
1st1,
AlexWaygood,
Fidget-Spinner,
JelleZijlstra,
asvetlov,
berkerpeksag,
brettcannon,
encukou,
ericsnowcurrently,
ericvsmith,
erlend-aasland,
ethanfurman,
gvanrossum,
iritkatriel,
lysnikolaou,
markshannon,
ncoghlan,
pablogsal,
rhettinger,
vsajip and
warsaw
as code owners
AlexWaygood
removed request for
a team,
1st1,
AlexWaygood,
asvetlov,
ezio-melotti,
iritkatriel,
kumaraditya303,
markshannon and
vsajip
When using xmlrpc, integer values smaller than MININT = -2147483648
or larger than MAXINT = 2147483647, an OverflowError:
"int exceeds XML-RPC limits" is thrown.
As this might be perfectly in line with the original XML-RPC spec, the
<i8> tag and <biginteger> has evolved and even is used in the library on
the receiving end.
This patch will change the behavior in the sense that 32 bit integer
values will still be sent with the <int> tag, while larger (smaller)
numbers are enclosed with the <i8> tag or <biginteger> tag respectively.
Minimal code example to test:
>>> import xmlrpc.client
>>> xmlrpc.client.dumps(("bla",2147483648))
Signed-off-by: Matthias Schoepfer <m.schoepfer@rethinkrobotics.com>
Co-authored-by: Erick Kramer <e.kramer@rethinkrobotics.com>
Member
|
I'll close for now; see discussion on the issue -- PyPI would be a better place for new XMLRPC features. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using xmlrpc, integer values smaller than MININT = -2147483648
or larger than MAXINT = 2147483647, an OverflowError:
"int exceeds XML-RPC limits" is thrown.
As this might be perfectly in line with the original XML-RPC spec, the
tag and has evolved and even is used in the library on
the receiving end.
This patch will change the behavior in the sense that 32 bit integer
values will still be sent with the tag, while larger (smaller)
numbers are enclosed with the tag or tag respectively.
Minimal code example to test:
Signed-off-by: Matthias Schoepfer m.schoepfer@rethinkrobotics.com
Co-authored-by: Erick Kramer e.kramer@rethinkrobotics.com