X Tutup
The Wayback Machine - https://web.archive.org/web/20250608231441/https://github.com/python/cpython/pull/103331
Skip to content

gh-103326: Remove Python/importlib.h #103331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking 鈥淪ign up for GitHub鈥, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 12, 2023
Merged

gh-103326: Remove Python/importlib.h #103331

merged 4 commits into from
Apr 12, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Apr 7, 2023 鈥
edited by bedevere-bot
Loading

Looks like there are no more references of it 馃帀
(except history)

禄 ag importlib.h
Misc/HISTORY
6777:- Issue #15466: Stop using TYPE_INT64 in marshal, to make importlib.h (and other
7108:- Issue #15431: Add _freeze_importlib project to regenerate importlib.h on
7448:  (Modules/_freeze_importlib) to build Python/importlib.h.
8949:- Issue #13591: A bug in importlib has been fixed that caused import_module

Lib/importlib/_bootstrap.py
675:                # See # https://docs.python.org/3/library/importlib.html#importlib.abc.Loader.load_module

@bedevere-bot bedevere-bot mentioned this pull request Apr 7, 2023
Closed
@sobolevn sobolevn requested a review from brettcannon April 7, 2023 05:41
@sobolevn
Copy link
Member Author

sobolevn commented Apr 7, 2023

No idea what is going on:

Getting the list of files that have been added/changed ... 5 files
Fixing Python file whitespace ... 1 file:
  Tools/c-analyzer/cpython/_parser.py

I didn't touch any whitespaces 馃

@sobolevn
Copy link
Member Author

sobolevn commented Apr 7, 2023

Oh, I see. This file contains tabs in https://github.com/python/cpython/blob/main/Tools/c-analyzer/cpython/_parser.py#L111-L116 and many other places. I don't think that it should be fixed, because tsv is named tab separated values for a reason.

I will open an new issue to ignore this file from this check.

@sobolevn
Copy link
Member Author

sobolevn commented Apr 7, 2023

I've opened #103334 to fix this problem. I don't think that it is a blocker.

@brettcannon brettcannon requested a review from hugovk as a code owner April 11, 2023 00:56
hugovk
hugovk reviewed Apr 11, 2023
View reviewed changes
sobolevn and others added 2 commits April 11, 2023 09:03
@sobolevn @hugovk
Apply suggestions from code review
1a2cea4 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@sobolevn
Merge branch 'main' into issue-103326
11ec05d
@brettcannon brettcannon merged commit 7f3c106 into python:main Apr 12, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Apr 18, 2023
@sobolevn @brettcannon
@hugovk @aisk
pythongh-103326: Remove Python/importlib.h (pythonGH-103331)
8692fd0 
Co-authored-by: Brett Cannon <brett@python.org>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk left review comments

@brettcannon brettcannon brettcannon approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Assignees

@brettcannon brettcannon

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sobolevn @brettcannon @hugovk @erlend-aasland @bedevere-bot
X Tutup