X Tutup
The Wayback Machine - https://web.archive.org/web/20230329061656/https://github.com/PowerShell/PowerShell/pull/18222
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set-Clipboard -AsOSC52 #18222

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Set-Clipboard -AsOSC52 #18222

wants to merge 4 commits into from

Conversation

dkaszews
Copy link
Contributor

@dkaszews dkaszews commented Oct 5, 2022 •
edited

PR Summary

Add -AsOSC52 switch to Set-Clipboard

PR Context

Closes #18116

PR Checklist

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Oct 6, 2022
@msftbot msftbot bot added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Oct 10, 2022
@dkaszews dkaszews requested review from SteveL-MSFT and removed request for daxian-dbw and adityapatwardhan October 10, 2022 19:53
SteveL-MSFT
SteveL-MSFT approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveL-MSFT SteveL-MSFT added the Hacktoberfest-Accepted Accepted to participate in Hacktoberfest label Oct 10, 2022
@dkaszews
Copy link
Contributor Author

Failures in Windows CI do not seem related to the change - they passed before the rename suggested by @SteveL-MSFT

@iSazonov
Copy link
Collaborator

I restarted Windows-CI.

@iSazonov iSazonov added the Documentation Needed Documentation is needed label Oct 11, 2022
@iSazonov
Copy link
Collaborator

@dkaszews Please create new issue in Docs repository and add reference to it in the PR check list.

@dkaszews dkaszews mentioned this pull request Oct 11, 2022
Open
2 tasks
@dkaszews
Copy link
Contributor Author

@iSazonov Done

@iSazonov iSazonov removed the Documentation Needed Documentation is needed label Oct 11, 2022
@msftbot msftbot bot added the Review - Needed The PR is being reviewed label Oct 19, 2022
@msftbot
Copy link

msftbot bot commented Oct 19, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

daxian-dbw
daxian-dbw reviewed Oct 25, 2022
View reviewed changes
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment.

src/Microsoft.PowerShell.Commands.Management/commands/management/SetClipboardCommand.cs Outdated Show resolved Hide resolved
@dkaszews
Copy link
Contributor Author

@SteveL-MSFT Can you please review? I can remove this -Remote alias as it was my own idea and may be misleading to some, I just would like to get it merged.

@SteveL-MSFT SteveL-MSFT added the WG-Cmdlets general cmdlet issues label Mar 8, 2023
@SteveL-MSFT
Copy link
Member

Sorry for the delay, I've queued this up to the Cmdlets WG to discuss

@msftbot msftbot bot removed the Review - Needed The PR is being reviewed label Mar 8, 2023
@dkaszews dkaszews changed the title Set-Clipboard -Remote with OSC52 Set-Clipboard -UsingOSC52 Mar 15, 2023
@dkaszews dkaszews changed the title Set-Clipboard -UsingOSC52 Set-Clipboard -AsOSC52 Mar 15, 2023
@pull-request-quantifier
Copy link

This PR has 14 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +13 -1
Percentile : 5.6%

Total files changed: 1

Change summary by file extension:
.cs : +13 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  👌  👎 (Email)
Customize PullRequestQuantifier for this repository.

@msftbot msftbot bot added the Review - Needed The PR is being reviewed label Mar 28, 2023
@msftbot
Copy link

msftbot bot commented Mar 28, 2023

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxian-dbw daxian-dbw daxian-dbw left review comments

@iSazonov iSazonov iSazonov approved these changes

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

Assignees

@TravisEz13 TravisEz13

Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small Hacktoberfest-Accepted Accepted to participate in Hacktoberfest Review - Needed The PR is being reviewed WG-Cmdlets general cmdlet issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set-Clipboard -Remote with OSC52
5 participants
@dkaszews @iSazonov @SteveL-MSFT @daxian-dbw @TravisEz13
X Tutup