X Tutup
The Wayback Machine - https://web.archive.org/web/20200918095354/https://github.com/PowerShell/PSScriptAnalyzer/pull/1450
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup csproj files: Remove code duplication for Configuration and entries in Rules project, since it depends on Engine project #1450

Merged
merged 1 commit into from Apr 20, 2020

Conversation

@bergmeister
Copy link
Collaborator

bergmeister commented Apr 18, 2020

PR Summary

This is a cleanup of PR #1425:
After that PR, building locally via Visual Studio or dotnet build was not working any more because it did not cater for the Configuration being either Debug or Release. Since the code for Configuration PSV6Debug and PSV6Releasewere the same the condition fore the configuration was removed, thereby removing unnecessary code duplication and making the case ofDebugorReleasework again, whilst not changing existing behaviour. Also: Since theRulesproject depends on theEngine` project, there is no need to duplicate the reference to SMA (which was actually forgotten to be switched from the SDK to SMA in one project).

PR Checklist

…ntries in Rules project, since it depends on Engine project
@bergmeister bergmeister requested review from rjmholt and JamesWTruher Apr 18, 2020
@bergmeister bergmeister marked this pull request as ready for review Apr 18, 2020
@bergmeister bergmeister merged commit 89f2846 into PowerShell:master Apr 20, 2020
12 checks passed
12 checks passed
PSScriptAnalyzer-CI Build #20200418.3 succeeded
Details
PSScriptAnalyzer-CI (Build Full_Build) Build Full_Build succeeded
Details
PSScriptAnalyzer-CI (Test Ubuntu_16_04) Test Ubuntu_16_04 succeeded
Details
PSScriptAnalyzer-CI (Test Ubuntu_18_04) Test Ubuntu_18_04 succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2016_PowerShell_5_1) Test Windows_Server2016_PowerShell_5_1 succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2016_PowerShell_Core) Test Windows_Server2016_PowerShell_Core succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2019_PowerShell_5_1) Test Windows_Server2019_PowerShell_5_1 succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2019_PowerShell_Core) Test Windows_Server2019_PowerShell_Core succeeded
Details
PSScriptAnalyzer-CI (Test macOS_10_14_Mojave) Test macOS_10_14_Mojave succeeded
Details
PSScriptAnalyzer-CI (Test macOS_10_15_Catalina) Test macOS_10_15_Catalina succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.
X Tutup