Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate Newtonsoft.Json from 12.0.2 to 12.0.3 in Compatibility project as well #1447
Conversation
… as well
… into bergmeister-patch-3
|
That's funny, one of the tests jobs failed because I merged PR #1446 AFTER the build had already started, meaning that when the test job checked out out the repo, it executed the newly added tests but of course the build artefact did not have the code to make it pass that test... I suppose this does not happen very often but it's good to be aware of this because the traditional re-run of the test stage did not help here of course. Technically, we should probably upload the Tests folder as an artefact to avoid this but that would make CI unnecessarily more complex I fear. |
bergmeister
merged commit 9098e76
into
master
13 checks passed
13 checks passed
PSScriptAnalyzer-CI (Test Windows_Server2016_PowerShell_5_1)
Test Windows_Server2016_PowerShell_5_1 succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2016_PowerShell_Core)
Test Windows_Server2016_PowerShell_Core succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2019_PowerShell_5_1)
Test Windows_Server2019_PowerShell_5_1 succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2019_PowerShell_Core)
Test Windows_Server2019_PowerShell_Core succeeded
Details
license/cla
All CLA requirements met.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bergmeister commentedApr 17, 2020
PR Summary
PowerShell 6.2.4 uses this version as well, therefore not an issue: https://github.com/PowerShell/PowerShell/blob/v6.2.4/src/System.Management.Automation/System.Management.Automation.csproj
The upgrade to this version technically already happened in PR #1425 but this project was did not get updates.
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.