X Tutup
The Wayback Machine - https://web.archive.org/web/20200918095325/https://github.com/PowerShell/PSScriptAnalyzer/pull/1403
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vmImage in yaml and merge build definitions into 1 by using jobs. Disable all AppVeyor images except for WMF4. Disable flaky UseCompatibleCommand tests on Ubuntu in CI #1403

Merged
merged 15 commits into from Feb 3, 2020

Conversation

@bergmeister
Copy link
Collaborator

bergmeister commented Feb 2, 2020

PR Summary

  • Use vmImage in yaml to merge all build definitions into 1 PSScriptAnalyzer-CI build definition by using jobs instead of defining the image in the build definition itself. This means the Ubuntu/macOs/Windows specific build definitions can be deleted after this PR. This reduces maintenance in Azure DevOps and makes it easier for us adapt for upcoming image changes. With that we now also test against both Ubuntu versions and using jobs prepares us for using multi-stage pipelines as the next step (there isn't really a benefit in terms of time-savings though). In a PR the individual stages are reported individually but I don't think we can have badges for the individual jobs.
  • Since Azure DevOps seems to work fine, we can disable the other images in AppVeyor except for WMF4, for which Azure Pipelines does not have a hosted image for
  • The sporadic failures in the UseCompatibleCommand test suite change over time, therefore disabling the test cases individually was not working well.
  • Add build badge

PR Checklist

@bergmeister bergmeister changed the title WIP: try using multi-job yaml with different images Use vmImage in yaml to merge Ubuntu%macOS build definitions into 1 'Unix' build definition. Disable all AppVeyor images except for WMF4. Disable flaky UseCompatibleCommand tests on Ubuntu in CI Feb 2, 2020
@bergmeister bergmeister requested review from rjmholt and JamesWTruher Feb 2, 2020
@bergmeister bergmeister changed the title Use vmImage in yaml to merge Ubuntu%macOS build definitions into 1 'Unix' build definition. Disable all AppVeyor images except for WMF4. Disable flaky UseCompatibleCommand tests on Ubuntu in CI Use vmImage in yaml to merge Ubuntu & macOS build definitions into 1 'Unix' build definition. Disable all AppVeyor images except for WMF4. Disable flaky UseCompatibleCommand tests on Ubuntu in CI Feb 2, 2020
@bergmeister bergmeister changed the title Use vmImage in yaml to merge Ubuntu & macOS build definitions into 1 'Unix' build definition. Disable all AppVeyor images except for WMF4. Disable flaky UseCompatibleCommand tests on Ubuntu in CI Use vmImage in yaml and merge build definitions into 1 by using jobs. Disable all AppVeyor images except for WMF4. Disable flaky UseCompatibleCommand tests on Ubuntu in CI Feb 2, 2020
@bergmeister bergmeister marked this pull request as ready for review Feb 2, 2020
bergmeister added 2 commits Feb 2, 2020
@rjmholt
rjmholt approved these changes Feb 3, 2020
@bergmeister bergmeister merged commit d5cb76f into PowerShell:master Feb 3, 2020
8 checks passed
8 checks passed
PSScriptAnalyzer-CI Build #20200202.11 succeeded
Details
PSScriptAnalyzer-CI (Ubuntu_16_04) Ubuntu_16_04 succeeded
Details
PSScriptAnalyzer-CI (Ubuntu_18_04) Ubuntu_18_04 succeeded
Details
PSScriptAnalyzer-CI (Windows_PowerShell_5_1) Windows_PowerShell_5_1 succeeded
Details
PSScriptAnalyzer-CI (Windows_PowerShell_Core) Windows_PowerShell_Core succeeded
Details
PSScriptAnalyzer-CI (macOS) macOS succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.
X Tutup