Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd ImplementingType to RuleInfo object #1250
Merged
Conversation
|
Apart from a small comment about a property, looks good to me, thanks. |
| /// <summary> | ||
| /// ImplementingType : The type which implements the rule. | ||
| /// </summary> | ||
| [SuppressMessage("Microsoft.Performance", "CA1811:AvoidUncalledPrivateCode")] |
This comment has been minimized.
This comment has been minimized.
bergmeister
Jun 5, 2019
Collaborator
I think the CA rule is right to call this out. C# has auto-properties now that can simplify this property to public Type { get; } whereby the private setter is included by default.
This comment has been minimized.
This comment has been minimized.
JamesWTruher
Jun 5, 2019
Author
Member
yah - I didn't want to change them all, so I just followed the previous example for consistency. I'm certainly happy to change all of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
JamesWTruher commentedJun 4, 2019
PR Summary
This will enable easier creation of settings file validation and settings file template creation.
Navigating to the actual implementation of the rule is quite difficult, by providing the implementing type of the rule, this becomes much easier. This is similar to how
CmdletInfoworks in PowerShell where there is an ImplementingType property on the CmdletInfo object.This will enable a couple of things; first, we'll be able to create validation of settings file without translating the rule name to the type that implements (so you can very easily retrieve the configurable properties). Second, it will also be possible to write tools to create templates for settings.
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.