Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPrevent PSCloseBrace crash if hashtable definition start on first token and there is a PSCloseBrace violation #1235
Conversation
…is a PSCloseBrace violation
|
LGTM! |
|
I'm not sure the call to |
| } | ||
|
|
||
| It "Should not crash when hashtable is defined on first token" { | ||
| $def = @' |
This comment has been minimized.
This comment has been minimized.
JamesWTruher
May 16, 2019
Member
I think this can also be written as follows:
$def = "@{ `n Key = 1 }"
and it will cause the same error
This comment has been minimized.
This comment has been minimized.
JamesWTruher
May 16, 2019
Member
and it's a very specific set of characters. This "@{key=1}" doesn't cause the problem but "@{``nkey=1}" does
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| $violations.Count | Should -Be 1 | ||
| Invoke-Formatter -ScriptDefinition $def -ErrorAction Stop |
This comment has been minimized.
This comment has been minimized.
JamesWTruher
May 16, 2019
Member
There doesn't seem to be an assertion here. Since the formatter uses the same rule, this seems superfluous. (do you want an explicit test for the formatter?)
This comment has been minimized.
This comment has been minimized.
bergmeister
May 29, 2019
Author
Collaborator
The assertion here is that the formatter does not throw an exception. The call to Invoke-ScriptAnalyzer is the core unit test but the call to Invoke-Formatter is the integration test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bergmeister commentedMay 5, 2019
PR Summary
Fixes #1219
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.