X Tutup
The Wayback Machine - https://web.archive.org/web/20200918094639/https://github.com/PowerShell/PSScriptAnalyzer/pull/1105
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify reference to Microsoft.Management.Infrastructure and update System.Reflection.TypeExtensions package #1105

Merged
merged 6 commits into from Mar 8, 2019

Conversation

@bergmeister
Copy link
Collaborator

bergmeister commented Nov 26, 2018

PR Summary

As per title

PR Checklist

…tem.Reflection.TypeExtensions package
@bergmeister bergmeister added this to the 1.18 milestone Nov 26, 2018
@bergmeister bergmeister self-assigned this Nov 26, 2018
Copy link
Member

JamesWTruher left a comment

I'm not sure that this will work. I wasn't aware that Microsoft.Management.Infrastructure was appropriate for core.

@bergmeister
Copy link
Collaborator Author

bergmeister commented Dec 15, 2018

Why? All I am changing is to make fullclr use the latest released version and eliminate code-duplication, the NuGet package supports net451 and netstandard1.6 or are you saying you wouldn't expect it to work at runtime? The Nuget reference is needed for coreclr and fullclr, otherwise the project won't compile.

bergmeister added 4 commits Jan 9, 2019
…nalyzer into NuGetupdates

# Conflicts:
#	Rules/Rules.csproj
@rjmholt
rjmholt approved these changes Mar 5, 2019
@rjmholt
Copy link
Member

rjmholt commented Mar 5, 2019

It looks like we were already pulling in MMI for netstandard, I assume for DSC rules of some kind. I'm guessing that this MMI will work on Core to the extent that DSC does. Anyway, it just looks like a merge of versions, so that looks good to me

@rjmholt rjmholt requested review from rjmholt and JamesWTruher Mar 5, 2019
@rjmholt
rjmholt approved these changes Mar 5, 2019
…nalyzer into NuGetupdates

# Conflicts:
#	Rules/Rules.csproj
@rjmholt
rjmholt approved these changes Mar 5, 2019
@bergmeister bergmeister merged commit 012fd5e into PowerShell:development Mar 8, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
bergmeister added a commit to bergmeister/PSScriptAnalyzer that referenced this pull request Mar 22, 2019
…tem.Reflection.TypeExtensions package (PowerShell#1105)

* Unify reference to Microsoft.Management.Infrastructure and update System.Reflection.TypeExtensions package

* trigger ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.
X Tutup