X Tutup
The Wayback Machine - https://web.archive.org/web/20200918094616/https://github.com/PowerShell/PSScriptAnalyzer/pull/1086
Skip to content

/ PSScriptAnalyzer

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps SDK version to 2.1.401 #1086

Merged
merged 8 commits into from Oct 23, 2018
Merged

Bumps SDK version to 2.1.401 #1086

merged 8 commits into from Oct 23, 2018

Conversation

@wilmardo
Copy link
Contributor

wilmardo commented Oct 22, 2018 •
edited

PR Summary

Implements: #1085

Updates SDK version to 2.1.401 in global.json

PR Checklist
@wilmardo
Bumps SDK version to 2.1.401
1f5001b
@bergmeister
bergmeister reviewed Oct 22, 2018
View changes
Copy link
Collaborator

bergmeister left a comment

Thanks, the change looks ok but please update the link in the readme as well. I don't know why but the CI trigger does not seem to work today. cc @JamesWTruher
@wilmardo
Updates version and url in README
Loading status checks…
17f6341
@wilmardo
Copy link
Contributor Author

wilmardo commented Oct 22, 2018

The version and link in the readme are updated as well.
Also changed or newer to or newer patch release since a newer version which isn't a patch release of 2.1.401 will trow an error as stated in the docs:

  • If the specified SDK version is found on the machine, that exact version is used.
  • If the specified SDK version can't be found on the machine, the latest installed SDK patch version of that version is used. Latest installed SDK patch version can be either release or pre-release - the highest version number wins. In .NET Core 2.1 and higher, the patch versions lower than the patch version specified are ignored in the SDK selection.
  • If the specified SDK version and an appropriate SDK patch version can't be found, an error is thrown.
@bergmeister
trigger ci
Loading status checks…
f4dc3a2
@msftclas
Copy link

msftclas commented Oct 22, 2018 •
edited

CLA assistant check
All CLA requirements met.
@bergmeister
try trigger ci again
Loading status checks…
5d740a8
@wilmardo wilmardo mentioned this pull request Oct 22, 2018
Closed
bergmeister added 4 commits Oct 22, 2018
@bergmeister
try trigger ci again
Loading status checks…
bae434e
@bergmeister
try trigger ci again
Loading status checks…
1643846
@bergmeister
try trigger ci again
Loading status checks…
baede9f
@bergmeister
try trigger ci again
Loading status checks…
9935d47
@bergmeister
bergmeister approved these changes Oct 23, 2018
View changes
Copy link
Collaborator

bergmeister left a comment

Looks good to me and the CI build is green now as well after the GitHub outage
@bergmeister bergmeister merged commit 2df52ab into PowerShell:development Oct 23, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details
bergmeister added a commit to bergmeister/PSScriptAnalyzer that referenced this pull request Mar 22, 2019
@wilmardo @bergmeister
Bump .Net Core SDK version to 2.1.401 (PowerShell#1086)
f7a0741 
* Bumps SDK version to 2.1.401

* Updates version and url in README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergmeister bergmeister

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@wilmardo @msftclas @bergmeister
You can’t perform that action at this time.
X Tutup