X Tutup
The Wayback Machine - https://web.archive.org/web/20200918094622/https://github.com/PowerShell/PSScriptAnalyzer/pull/1084
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pwsh 6.0.2 installation code during AppVeyor build boostrap that is not needed any more #1084

Merged

Conversation

@wilmardo
Copy link
Contributor

wilmardo commented Oct 22, 2018

PR Summary

Removes the update of pwsh from 6.0.0 to 6.0.2 on AppVeyor Windows image since the image is updated. See the list of installed software and the 16 September 2018 update.

PR Checklist

@wilmardo wilmardo mentioned this pull request Oct 22, 2018
6 of 6 tasks complete
Copy link
Collaborator

bergmeister left a comment

thank for the contribution but this change will be superseded by PR #1082 that will be merged soon and also removes this code.

@wilmardo
Copy link
Contributor Author

wilmardo commented Oct 22, 2018

Ah cool! Scanned the open PR's but apparently a bit to quick ;)

Closing this in favor of #1082

@wilmardo wilmardo closed this Oct 22, 2018
@bergmeister
Copy link
Collaborator

bergmeister commented Oct 23, 2018

Re-open since the PR mentioned above did not remove this code section.

@bergmeister bergmeister reopened this Oct 23, 2018
@bergmeister bergmeister changed the title Removes pwsh update to 6.0.2 on AppVeyor Windows images Remove pwsh 6.0.2 installation code during AppVeyor build boostrap that is not needed any more Oct 24, 2018
@bergmeister bergmeister requested a review from rjmholt Oct 24, 2018
@bergmeister bergmeister merged commit 1f855ac into PowerShell:development Oct 30, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
bergmeister added a commit to bergmeister/PSScriptAnalyzer that referenced this pull request Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.
X Tutup