X Tutup
The Wayback Machine - https://web.archive.org/web/20230321181527/https://github.com/PowerShell/PowerShell/issues/19372
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IFeedbackProvider should be able to be called when there is not an error #19372

Open
JamesWTruher opened this issue Mar 20, 2023 · 2 comments
Open

IFeedbackProvider should be able to be called when there is not an error #19372

JamesWTruher opened this issue Mar 20, 2023 · 2 comments
Labels
Issue-Enhancement the issue is more of a feature request than a bug Needs-Triage The issue is new and needs to be triaged by a work group.

Comments

@JamesWTruher
Copy link
Member

Summary of the new feature / enhancement

It should be possible to call the predictor in those cases where there wasn't an error.
For example, if the user types a command which was successful, but there is a better way to express the operation.
ex.

PS> uname -a

could be prompted to run

PS> uname -a | jc --uname | convertfrom-json

if the jc command is installed.

Proposed technical implementation details (optional)

No response
@JamesWTruher JamesWTruher added Issue-Enhancement the issue is more of a feature request than a bug Needs-Triage The issue is new and needs to be triaged by a work group. labels Mar 20, 2023
@JamesWTruher
Copy link
Member Author

this is related to: #19364

@daxian-dbw
Copy link
Member

@JamesWTruher I think you mean the IFeedbackProvider.

@SteveL-MSFT SteveL-MSFT changed the title ICommandPredictor should be able to be called when there is not an error IFeedbackProvider should be able to be called when there is not an error Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Enhancement the issue is more of a feature request than a bug Needs-Triage The issue is new and needs to be triaged by a work group.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daxian-dbw @JamesWTruher
X Tutup