X Tutup
The Wayback Machine - https://web.archive.org/web/20220323092718/https://github.com/nodejs/node/pull/38395
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move slower tests into pummel and skip on slow devices #38395

Merged
merged 1 commit into from Apr 27, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 25, 2021

Move slower tests to pummel and skip on Raspberry Pi devices in CI.

Refs: #34289 (comment)

@Trott Trott requested a review from targos Apr 25, 2021
@nodejs-github-bot

This comment has been hidden.

targos
targos approved these changes Apr 25, 2021
@targos targos added the test label Apr 25, 2021
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Apr 25, 2021

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Apr 25, 2021

@Trott
Copy link
Member Author

@Trott Trott commented Apr 26, 2021

Fast-track to help our backed-up arm-fanned CI jobs?

@Trott Trott added the fast-track label Apr 26, 2021
panva
panva approved these changes Apr 26, 2021
@Trott Trott removed the fast-track label Apr 27, 2021
Move slower tests to pummel and skip on Raspberry Pi devices in CI.

Refs: nodejs#34289 (comment)

PR-URL: nodejs#38395
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@Trott
Copy link
Member Author

@Trott Trott commented Apr 27, 2021

Landed in 7f56307

@Trott Trott merged commit 7f56307 into nodejs:master Apr 27, 2021
16 checks passed
@Trott Trott deleted the move-some-pummels branch Apr 27, 2021
targos added a commit that referenced this issue Apr 29, 2021
Move slower tests to pummel and skip on Raspberry Pi devices in CI.

Refs: #34289 (comment)

PR-URL: #38395
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@targos targos mentioned this pull request May 3, 2021
@targos targos added the backport-blocked-v14.x label May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-blocked-v14.x test
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
X Tutup