X Tutup
The Wayback Machine - https://web.archive.org/web/20230131200320/https://github.com/nodejs/node/pull/46314
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x backport] stream: implement finished() for ReadableStream and WritableStream #46314

Draft
wants to merge 1 commit into
base: v18.x-staging
Choose a base branch
from
Draft

[v18.x backport] stream: implement finished() for ReadableStream and WritableStream #46314

wants to merge 1 commit into from
+301 −9

Conversation

debadree25
Copy link
Contributor

Refs: #39316
PR-URL: #46205
Reviewed-By: Robert Nagy ronagy@icloud.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Darshan Sen raisinten@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

@debadree25
stream: implement finished() for ReadableStream and WritableStream
7902a99 
Refs: nodejs#39316
PR-URL: nodejs#46205
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@nodejs-github-bot
Copy link
Contributor

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. web streams labels Jan 23, 2023
@debadree25
Copy link
Contributor Author

cc @aduh95

@aduh95
Copy link
Contributor

aduh95 commented Jan 23, 2023

We need to wait on #46312 to land first, and backport the three PRs in one backport PR (i.e. you need to cherry-pick the two other commits onto this branch). I'm going to convert this to draft if that's OK as this can't happen until #46312 lands.

@aduh95 aduh95 marked this pull request as draft Jan 23, 2023
@debadree25
Copy link
Contributor Author

Sure no issue!

@debadree25
Copy link
Contributor Author

So overall would need to cherry-pick #46205, #46190, #46315 and #46312 into this single PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. web streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@debadree25 @nodejs-github-bot @aduh95
X Tutup