Fix Visual Studio installation detection for Arm64 #46420
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
Blackhex
force-pushed
the
fix-vswhere-arm64
branch
2 times, most recently
from
e85db92
to
628eae5
Compare
Blackhex
commented
Jan 30, 2023
| @@ -257,7 +256,7 @@ echo Looking for Visual Studio 2022 | |||
| @rem cleared first as vswhere_usability_wrapper.cmd doesn't when it fails to | |||
| @rem detect the version searched for | |||
| if not defined target_env set "VCINSTALLDIR=" | |||
| call tools\msvs\vswhere_usability_wrapper.cmd "[17.0,18.0)" "prerelease" | |||
There was a problem hiding this comment.
Is there any reason why pre-release Build Tools are used? The stable 17.4.4 version should be enough to compile for Arm64.
Blackhex
force-pushed
the
fix-vswhere-arm64
branch
2 times, most recently
from
02eac19
to
3aca22a
Compare
|
@nodejs/platform-windows-arm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When
vcbuild.bat arm64was run on Windows Arm64 machine, thevswhere_usability_wrapper.cmdwas detecting proper installation of Visual Studio according to presence of x64 Build Tools which fails when there is only Arm64 version of the Build Tools.