X Tutup
The Wayback Machine - https://web.archive.org/web/20230131200321/https://github.com/nodejs/node/pull/46371
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add trailing commas in test/pseudo-tty #46371

Merged
merged 1 commit into from Jan 29, 2023
Merged

test: add trailing commas in test/pseudo-tty #46371

merged 1 commit into from Jan 29, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 26, 2023

Only a few were missing in this folder, I added them and remove the folder from the linter override.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem. labels Jan 26, 2023
MoLow
MoLow approved these changes Jan 26, 2023
View changes
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Jan 26, 2023
@aduh95 aduh95 merged commit aa8a244 into nodejs:main Jan 29, 2023
28 checks passed
@aduh95
Copy link
Contributor Author

aduh95 commented Jan 29, 2023

Landed in aa8a244

@aduh95 aduh95 deleted the pseudo-tty-dangle branch Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@MoLow MoLow

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aduh95 @jasnell @MoLow @nodejs-github-bot
X Tutup