X Tutup
The Wayback Machine - https://web.archive.org/web/20230204195644/https://github.com/nodejs/node/pull/46249
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "src: let http2 streams end after session close" #46249

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Revert "src: let http2 streams end after session close" #46249

wants to merge 1 commit into from
+1 −11

Conversation

santigimeno
Copy link
Member

This reverts commit dee882e. Moved the test that demonstrated what this commit was fixing to the known_issues folder.

Fixes: #46234

@santigimeno
Revert "src: let http2 streams end after session close"
3619cb3 
This reverts commit dee882e.
Moved the test that demonstrated what this commit was fixing to the
`known_issues` folder.

Fixes: nodejs#46234
@nodejs-github-bot
Copy link
Contributor

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Jan 18, 2023
@santigimeno santigimeno mentioned this pull request Jan 18, 2023
Open
@santigimeno
Copy link
Member Author

Once this is merged, should we reopen #42713?

ronag
ronag approved these changes Jan 18, 2023
View changes
@ronag
Copy link
Member

ronag commented Jan 18, 2023

Would be nice with a regression test if possible.

@santigimeno
Copy link
Member Author

Would be nice with a regression test if possible.

I moved the original test to the known_issues folder. Is that what you're asking?

mcollina
mcollina approved these changes Jan 18, 2023
View changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

@nodejs/releasers this should be backported to v19.x, v18.x, and v16.x.

@mcollina mcollina added v16.x Issues that can be reproduced on v16.x or PRs targeting the v16.x-staging branch. v19.x Issues that can be reproduced on v19.x or PRs targeting the v19.x-staging branch. lts-watch-v18.x PRs that may need to be released in v18.x. lts-watch-v16.x PRs that may need to be released in v16.x. labels Jan 18, 2023
lpinca
lpinca approved these changes Jan 18, 2023
View changes
@RafaelGSS RafaelGSS added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 19, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @RafaelGSS. Please 👍 to approve.

@RafaelGSS
Copy link
Member

I requested the fast-track to include it in the next v19.x release (planning to create the proposal between Thursday and Friday).

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2023
@nodejs-github-bot
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/49097/

@nodejs-github-bot
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/49108/

@mcollina
Copy link
Member

The tests keep failing.

This was referenced Jan 21, 2023
Open
Open
Open
This was referenced Jan 24, 2023
Open
Open
@ronag
Copy link
Member

ronag commented Jan 25, 2023

The test failure looks weird. Skipped due to missing crypto but still fail? How is that possible? https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_withoutssl_x64/35560/testReport/junit/(root)/test/known_issues_test_http2_trailers_after_session_close/ @Trott

@ronag ronag removed the needs-ci PRs that need a full CI run. label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina

@fhinkel fhinkel

@lpinca lpinca

@cjihrig cjihrig

@ronag ronag

@RafaelGSS RafaelGSS

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. http2 Issues or PRs related to the http2 subsystem. lts-watch-v16.x PRs that may need to be released in v16.x. lts-watch-v18.x PRs that may need to be released in v18.x. v16.x Issues that can be reproduced on v16.x or PRs targeting the v16.x-staging branch. v19.x Issues that can be reproduced on v19.x or PRs targeting the v19.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node 18.13 HTTP/2 live lock
8 participants
@santigimeno @nodejs-github-bot @ronag @mcollina @RafaelGSS @fhinkel @lpinca @cjihrig
X Tutup