X Tutup
The Wayback Machine - https://web.archive.org/web/20230103120939/https://github.com/nodejs/node/pull/45629
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add cjs_module_lexer_version and base64_version #45629

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

src: add cjs_module_lexer_version and base64_version #45629

wants to merge 1 commit into from
+38 −2

Conversation

MrJithil
Copy link
Contributor

@MrJithil MrJithil commented Nov 26, 2022 •
edited

Ref: #45260

Added version info of cjs_module_lexer and base64_version

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Nov 26, 2022
@MrJithil MrJithil force-pushed the addCjsModuleLexerVersion branch from 31cef86 to 1791f9b Compare Nov 26, 2022
@MrJithil MrJithil changed the title build: add cjs_module_lexer_version build: add cjs_module_lexer_version and base64_version Nov 26, 2022
@MrJithil MrJithil force-pushed the addCjsModuleLexerVersion branch 6 times, most recently from f5d3e71 to 65d9864 Compare Nov 26, 2022
@MrJithil MrJithil changed the title build: add cjs_module_lexer_version and base64_version src: add cjs_module_lexer_version and base64_version Nov 26, 2022
@MrJithil MrJithil force-pushed the addCjsModuleLexerVersion branch from 65d9864 to 67ffed7 Compare Nov 26, 2022
@MrJithil MrJithil closed this Nov 27, 2022
@MrJithil MrJithil reopened this Nov 27, 2022
@MrJithil MrJithil mentioned this pull request Nov 27, 2022
Closed
6 tasks
@MrJithil
Copy link
Contributor Author

MrJithil commented Nov 27, 2022

Can we add process label if I am not wrong.

jasnell
jasnell reviewed Nov 27, 2022
View changes
tools/update-deps-version-files.sh Outdated Show resolved Hide resolved
@MrJithil MrJithil force-pushed the addCjsModuleLexerVersion branch 2 times, most recently from 3fff7bc to 03da04e Compare Nov 29, 2022
@MrJithil MrJithil closed this Nov 29, 2022
@MrJithil MrJithil reopened this Nov 29, 2022
@MrJithil MrJithil closed this Dec 1, 2022
@MrJithil MrJithil reopened this Dec 1, 2022
@MrJithil MrJithil closed this Dec 2, 2022
@MrJithil MrJithil reopened this Dec 2, 2022
@MrJithil MrJithil force-pushed the addCjsModuleLexerVersion branch from 03da04e to 3b1d99c Compare Dec 12, 2022
@MrJithil
Copy link
Contributor Author

MrJithil commented Dec 12, 2022

Resolved conflicts

@MrJithil
src: add cjs_module_lexer_version base64_version
55d8f11 
src: add cjs_module_lexer_version base64_version
@MrJithil MrJithil force-pushed the addCjsModuleLexerVersion branch from 3b1d99c to 55d8f11 Compare Dec 23, 2022
@MrJithil
Copy link
Contributor Author

MrJithil commented Jan 3, 2023

Can we merge this?
@jasnell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@JungMinu JungMinu

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MrJithil @jasnell @JungMinu @nodejs-github-bot
X Tutup