X Tutup
The Wayback Machine - https://web.archive.org/web/20230317203005/https://github.com/PowerShell/PowerShell/pull/18546
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AllowInsecureRedirect switch to Web cmdlets #18546

Merged
merged 14 commits into from Jan 12, 2023
Merged

Add AllowInsecureRedirect switch to Web cmdlets #18546

merged 14 commits into from Jan 12, 2023

Conversation

CarloToso
Copy link
Contributor

@CarloToso CarloToso commented Nov 13, 2022 •
edited by iSazonov

PR Summary

WebCmdlets add -AllowInsecureRedirect switch to enable HTTPS to HTTP redirect.
System.Net.Http.HttpClient disables insecure redirects, this PR bypasses the problem, unfortunately at the moment I can't find a way to make it honor the -MaximumRedirects flag, so I have disabled using both of them toghether.
I'm eager to receive your feedback on this feature and some input on how to fix and re-enable the -MaximumRedirect flag.
I'm going to add some tests to show what works and what doesn't work yet.

PR Context

Fixes #2896 and #18541

PR Checklist

@iSazonov
Copy link
Collaborator

unfortunately at the moment I can't find a way to make it honor the -MaximumRedirects flag

PowerShell/src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs

Lines 1045 to 1049 in f5eede6

// This indicates GetResponse will handle redirects.
if (handleRedirect)
{
handler.AllowAutoRedirect = false;
}

This says it is in GetResponse().

@CarloToso CarloToso marked this pull request as draft November 14, 2022 10:48
@CarloToso CarloToso changed the title Webcmdlets -AllowInsecureRedirect -> follow HTTP redirects from HTTPS WIP: Webcmdlets -AllowInsecureRedirect -> follow HTTP redirects from HTTPS Nov 14, 2022
@CarloToso
Copy link
Contributor Author

-AllowInsecureRedirect should now work with -MaximumRedirect.
I tested it with this code:

0..5 | ForEach-Object {Invoke-WebRequest https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck -AllowInsecureRedirect -MaximumRedirection $_}
0..5 | ForEach-Object {Invoke-RestMethod https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck -AllowInsecureRedirect -MaximumRedirection $_}
Invoke-WebRequest https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck -AllowInsecureRedirect 
Invoke-WebRequest https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck

I still have to remove some commented code.

@CarloToso CarloToso marked this pull request as ready for review November 15, 2022 00:29
@CarloToso
Copy link
Contributor Author 

Invoke-WebRequest https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck

1

Invoke-WebRequest https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck -AllowInsecureRedirect

2

0..5 | ForEach-Object {(Invoke-WebRequest https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck -AllowInsecureRedirect -MaximumRedirection $_).StatusCode}

3

Some inconsistent behaviours (increase redirects errors, status code 308) are fixed by PR #18536.

@iSazonov
Copy link
Collaborator

LGTM.

@CarloToso CarloToso changed the title WIP: Webcmdlets -AllowInsecureRedirect -> follow HTTP redirects from HTTPS Webcmdlets -AllowInsecureRedirect -> follow HTTP redirects from HTTPS Nov 15, 2022
@CarloToso CarloToso mentioned this pull request Nov 17, 2022
Merged
22 tasks
@CarloToso
Copy link
Contributor Author

CarloToso commented Nov 23, 2022 •
edited

@PaulHigin please review, thanks!

@msftbot msftbot bot added the Review - Needed The PR is being reviewed label Dec 1, 2022
@msftbot
Copy link

msftbot bot commented Dec 1, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@CarloToso
Copy link
Contributor Author

Is something blocking this PR?

@iSazonov
Copy link
Collaborator

Is something blocking this PR?

Yes, holydays :-)
I hope MSFT team will start active work after Jan 1.
Until that I can consider minor style changes and discuss/review code for already triaged issues.

@msftbot msftbot bot removed the Review - Needed The PR is being reviewed label Dec 17, 2022
@msftbot msftbot bot added the Review - Needed The PR is being reviewed label Dec 25, 2022
@msftbot
Copy link

msftbot bot commented Dec 25, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@CarloToso
Copy link
Contributor Author

I think that after this PR is merged I can work on fixing #14531, it should be similar.

@pull-request-quantifier
Copy link

This PR has 6 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +4 -2
Percentile : 2.4%

Total files changed: 1

Change summary by file extension:
.cs : +4 -2

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  👌  👎 (Email)
Customize PullRequestQuantifier for this repository.

This was referenced Jan 6, 2023
Merged
Merged
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jan 12, 2023
@iSazonov iSazonov assigned iSazonov and unassigned PaulHigin Jan 12, 2023
@msftbot msftbot bot removed the Review - Needed The PR is being reviewed label Jan 12, 2023
@iSazonov
Copy link
Collaborator

@please open new issue in Docs repository and add reference in the PR description.

@CarloToso CarloToso mentioned this pull request Jan 12, 2023
Closed
2 tasks
@CarloToso
Copy link
Contributor Author

CarloToso commented Jan 12, 2023 •
edited

@please open new issue in Docs repository and add reference in the PR description.

Done MicrosoftDocs/PowerShell-Docs#9689

@iSazonov iSazonov changed the title Webcmdlets -AllowInsecureRedirect -> follow HTTP redirects from HTTPS Add AllowInsecureRedirect switch to Web cmdlets Jan 12, 2023
@iSazonov iSazonov merged commit ca4b616 into PowerShell:master Jan 12, 2023
40 checks passed
@CarloToso CarloToso deleted the WebCmdlets-add--allowInsecureRedirect branch January 12, 2023 16:13
@CarloToso CarloToso mentioned this pull request Jan 13, 2023
Merged
CarloToso added a commit to CarloToso/PowerShell that referenced this pull request Jan 15, 2023
@CarloToso
Add AllowInsecureRedirect switch to Web cmdlets (PowerShell#18546)
a8a279f
@CarloToso CarloToso mentioned this pull request Jan 23, 2023
Closed
5 tasks
@msftbot
Copy link

msftbot bot commented Mar 14, 2023

🎉v7.4.0-preview.2 has been released which incorporates this pull request.🎉

Handy links:

@msftbot msftbot bot mentioned this pull request Mar 14, 2023
Closed
gregsdennis pushed a commit to gregsdennis/PowerShell that referenced this pull request Mar 15, 2023
@CarloToso @gregsdennis
Add AllowInsecureRedirect switch to Web cmdlets (PowerShell#18546)
3301545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iSazonov iSazonov iSazonov approved these changes

@PaulHigin PaulHigin

Assignees

@iSazonov iSazonov

Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invoke-WebRequest / Invoke-RestMethod fails to follow HTTP redirects from HTTPS
3 participants
@CarloToso @iSazonov @PaulHigin
X Tutup