X Tutup
The Wayback Machine - https://web.archive.org/web/20230103095354/https://github.com/nodejs/node/pull/46064
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: Keep PipeWrap::Open function consistent with TCPWrap #46064

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

src: Keep PipeWrap::Open function consistent with TCPWrap #46064

wants to merge 1 commit into from

Conversation

theanarkh
Copy link
Contributor

@theanarkh theanarkh commented Jan 2, 2023

Keep PipeWrap::Open function consistent with TCPWrap.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. labels Jan 2, 2023
@theanarkh theanarkh force-pushed the keep_the_return_value_of_open_function_consistent branch from de44085 to 2f2f384 Compare Jan 2, 2023
@theanarkh theanarkh force-pushed the keep_the_return_value_of_open_function_consistent branch from 2f2f384 to ab9f98a Compare Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@theanarkh @nodejs-github-bot
X Tutup