X Tutup
The Wayback Machine - https://web.archive.org/web/20230103120939/https://github.com/nodejs/node/pull/46020
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm: refactor to use validateStringArray #46020

Merged
merged 1 commit into from Jan 1, 2023
Merged

vm: refactor to use validateStringArray #46020

merged 1 commit into from Jan 1, 2023

Conversation

deokjinkim
Copy link
Contributor

@deokjinkim deokjinkim commented Dec 30, 2022

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Dec 30, 2022
aduh95
aduh95 approved these changes Dec 30, 2022
View changes
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 30, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 30, 2022
@nodejs-github-bot
Copy link
Contributor

nodejs-github-bot commented Dec 30, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/48767/

lpinca
lpinca approved these changes Dec 30, 2022
View changes
@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 1, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 1, 2023
@nodejs-github-bot nodejs-github-bot merged commit 5e43f3d into nodejs:main Jan 1, 2023
57 checks passed
@nodejs-github-bot
Copy link
Contributor

nodejs-github-bot commented Jan 1, 2023

Landed in 5e43f3d

RafaelGSS pushed a commit that referenced this pull request Jan 2, 2023
@deokjinkim @RafaelGSS
vm: refactor to use validateStringArray
6f1a180 
PR-URL: #46020
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca

@JungMinu JungMinu

@aduh95 aduh95

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@deokjinkim @nodejs-github-bot @lpinca @JungMinu @aduh95 @targos
X Tutup