X Tutup
The Wayback Machine - https://web.archive.org/web/20230103070948/https://github.com/nodejs/node/pull/46024
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(I18n): MSI installer French #46024

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(I18n): MSI installer French #46024

wants to merge 2 commits into from

Conversation

AugustinMauroy
Copy link
Member

@AugustinMauroy AugustinMauroy commented Dec 30, 2022

translation of MSI installer into French.

@nodejs-github-bot nodejs-github-bot added install Issues and PRs related to the installers. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Dec 30, 2022
abenhamdine
abenhamdine suggested changes Dec 31, 2022
View changes
tools/msvs/msi/i18n/en-us.wxl Outdated Show resolved Hide resolved
tools/msvs/msi/i18n/fr-BE.wxl Outdated Show resolved Hide resolved
@bnoordhuis
Copy link
Member

bnoordhuis commented Jan 2, 2023

See #45090 and #45138 - i18n is disabled in the installer. Merging this PR as-is won't do any good, the file isn't going to get used.

@AugustinMauroy
Copy link
Member Author

AugustinMauroy commented Jan 2, 2023

I had read the microsoft docs normally it's working. So if you can explain why it's ins't use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abenhamdine abenhamdine

Assignees
No one assigned
Labels
install Issues and PRs related to the installers. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AugustinMauroy @bnoordhuis @abenhamdine @nodejs-github-bot
X Tutup