X Tutup
The Wayback Machine - https://web.archive.org/web/20221225135851/https://github.com/python/typeshed/pull/9398
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial apriltag stubs #9398

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

johanvandegriff
Copy link

@johanvandegriff johanvandegriff commented Dec 21, 2022

https://pypi.org/project/apriltag/

Stubs for the "apriltag" library. I'm new to the contribution process so let me know if I missed something.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@johanvandegriff
Copy link
Author

johanvandegriff commented Dec 21, 2022

I'm confused about the failing runs. I removed the numpy import but this job is still saying it can't find numpy (line 53 of the log). Also this job is complaining about Use "list[T]" instead of "typing.List[T]" (PEP 585 syntax) but I don't use typing.List[T] anywhere.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Dec 21, 2022

The issue is that the package you're trying to add stubs for is a little broken. It has a runtime dependency on numpy, but doesn't declare that dependency in e.g. its setup.py

I also can't find a canonical source for the PyPI package you posted, and it hasn't been updated in half a decade, so not sure how you'd get that fixed.

https://github.com/swatbotics/apriltag has some version of the code, but says

Please note: I am not the maintainer of the pypi package listed at https://pypi.org/project/apriltag/ – GitHub issues filed here reporting problems with that package will be summarily closed. Sorry, I don't have time to support someone else's unofficial package.

If I were you, I'd consider forking the package and adding types to it directly

@johanvandegriff
Copy link
Author

johanvandegriff commented Dec 22, 2022

Thanks for your quick reply!

Since there was no repo, I just downloaded the source code from https://pypi.org/project/apriltag/#files

If there's no way to get this to work, should I close the pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants
X Tutup