X Tutup
The Wayback Machine - https://web.archive.org/web/20221223142429/https://github.com/python/cpython/issues/95882
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trackstack includes __aexit__ in contextlib which is not in previous versions #95882

Open
graingert opened this issue Aug 11, 2022 · 3 comments
Open

Trackstack includes __aexit__ in contextlib which is not in previous versions #95882

graingert opened this issue Aug 11, 2022 · 3 comments
Labels
3.11 3.12

Comments

@graingert
Copy link
Contributor

graingert commented Aug 11, 2022 •
edited by bedevere-bot 

import contextlib


@contextlib.asynccontextmanager
async def f():
    try:
        yield
    finally:
        pass

async def amain():
    async with f(): 1/0


with contextlib.closing(amain().__await__()) as gen:
    next(gen, None)
Traceback (most recent call last):
  File "/home/graingert/projects/cpython/demo.py", line 16, in <module>
    next(gen, None)
  File "/usr/lib/python3.11/contextlib.py", line 222, in __aexit__
    await self.gen.athrow(typ, value, traceback)
  File "/home/graingert/projects/cpython/demo.py", line 7, in f
    yield
  File "/home/graingert/projects/cpython/demo.py", line 12, in amain
    async with f(): 1/0
                    ~^~
ZeroDivisionError: division by zero

Originally posted by @graingert in #92118 (comment)

Linked PRs
@graingert
Copy link
Contributor Author

graingert commented Aug 11, 2022

see also #27024

@graingert
Copy link
Contributor Author

graingert commented Aug 11, 2022 •
edited

I think the test cases and code for contextlib.contextmanager and contextlib.ExitStack should be automatically generated from the test cases and code for contextlib.asynccontextmanager and contextlib.AsyncExitStack

this is done in httpcore with https://github.com/encode/httpcore/blob/master/unasync.py

@bedevere-bot bedevere-bot mentioned this issue Aug 11, 2022
Open
graingert added a commit to graingert/cpython that referenced this issue Aug 11, 2022
@graingert
pythongh-95882 fix traceback of exceptions propagated from inside a c…
8110f28 
…ontextlib.asynccontextmanager
@iritkatriel iritkatriel removed their assignment Aug 11, 2022
@iritkatriel
Copy link
Member

iritkatriel commented Aug 11, 2022

Unassigned myself since you are working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.11 3.12
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@graingert @iritkatriel
X Tutup