X Tutup
The Wayback Machine - https://web.archive.org/web/20221223141223/https://github.com/python/cpython/pull/29157/commits
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43974: Move Py_BUILD_CORE_MODULE into module code (GH-29157) #29157

Merged
merged 5 commits into from Oct 22, 2021
Merged

bpo-43974: Move Py_BUILD_CORE_MODULE into module code (GH-29157) #29157

merged 5 commits into from Oct 22, 2021

Commits on Oct 22, 2021

  1. bpo-43974: Move Py_BUILD_CORE_MODULE into module code 

    ``setup.py`` no longer defines ``Py_BUILD_CORE_MODULE``. Instead every
module defines the macro before ``#include "Python.h"`` unless
``Py_BUILD_CORE_BUILTIN`` is already defined.

``Py_BUILD_CORE_BUILTIN`` is defined for every module that is built by
``Modules/Setup``.

Signed-off-by: Christian Heimes <christian@python.org>
    @tiran
    tiran committed Oct 22, 2021
    51be18e

  2. PCbuild: Dont' define Py_BUILD_CORE_MODULE

    @tiran
    tiran committed Oct 22, 2021
    d47314a

  3. Simplify Modules/Setup 

    Makefile and makesetup already define ``Py_BUILD_CORE_BUILTIN`` and
include ``Modules/internal`` for us.
    @tiran
    tiran committed Oct 22, 2021
    80561b5

  4. Victor prefers a different style

    @tiran
    tiran committed Oct 22, 2021
    2783161

  5. _abc also requires Py_BUILD_CORE

    @tiran
    tiran committed Oct 22, 2021
    2b5f23a
X Tutup