X Tutup
The Wayback Machine - https://web.archive.org/web/20221218082930/https://github.com/python/cpython/pull/100052
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-100049: fix repr for mappingproxy in dictionary view example doc #100052

Merged
merged 3 commits into from Dec 10, 2022
Merged

gh-100049: fix repr for mappingproxy in dictionary view example doc #100052

merged 3 commits into from Dec 10, 2022

Conversation

ramvikrams
Copy link
Contributor

@ramvikrams ramvikrams commented Dec 6, 2022 •
edited

gh-100049: the output is changed for dictionary view objects example in the doc/library/stdtypes.rst

@bedevere-bot bedevere-bot mentioned this pull request Dec 6, 2022
Closed
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Dec 6, 2022
@ramvikrams ramvikrams changed the title gh-100049: the output is changed for dictionary view objects example gh-100049: the output is changed for dictionary view objects example in the doc/library/stdtypes.rst Dec 6, 2022
@eklunko
Copy link

eklunko commented Dec 6, 2022

@ramvikrams
You suggest the fix as follows:

- mappingproxy({'eggs': 2, 'sausage': 1, 'bacon': 1, 'spam': 500})
+ {'bacon': 1, 'spam': 500}

It seems the correct fix would be:

- mappingproxy({'eggs': 2, 'sausage': 1, 'bacon': 1, 'spam': 500})
+ mappingproxy({'bacon': 1, 'spam': 500})

@ramvikrams
Copy link
Contributor Author

ramvikrams commented Dec 6, 2022

@ramvikrams
You suggest the fix as follows:

- mappingproxy({'eggs': 2, 'sausage': 1, 'bacon': 1, 'spam': 500})
+ {'bacon': 1, 'spam': 500}

It seems the correct fix would be:

- mappingproxy({'eggs': 2, 'sausage': 1, 'bacon': 1, 'spam': 500})
+ mappingproxy({'bacon': 1, 'spam': 500})

Thanks I'll fix it

@netlify
Copy link

netlify bot commented Dec 7, 2022 •
edited

✅ Deploy Preview for python-cpython-preview ready!

Name Link
🔨 Latest commit f97ffdb
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/6390e5db5d68b400082a8608
😎 Deploy Preview https://deploy-preview-100052--python-cpython-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kumaraditya303 kumaraditya303 changed the title gh-100049: the output is changed for dictionary view objects example in the doc/library/stdtypes.rst gh-100049: fix repr for mappingproxy in dictionary view example Dec 10, 2022
@kumaraditya303 kumaraditya303 changed the title gh-100049: fix repr for mappingproxy in dictionary view example gh-100049: fix repr for mappingproxy in dictionary view example doc Dec 10, 2022
@kumaraditya303 kumaraditya303 merged commit 7c0fb71 into python:main Dec 10, 2022
19 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Dec 10, 2022

Thanks @ramvikrams for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@kumaraditya303
Copy link
Contributor

kumaraditya303 commented Dec 10, 2022

Thanks

@bedevere-bot
Copy link

bedevere-bot commented Dec 10, 2022

GH-100155 is a backport of this pull request to the 3.11 branch.

@bedevere-bot
Copy link

bedevere-bot commented Dec 10, 2022

GH-100156 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 10, 2022
@ramvikrams @miss-islington
pythongh-100049: fix repr for mappingproxy in dictionary view exa…
f04ebbb 
…mple doc (pythonGH-100052)

(cherry picked from commit 7c0fb71)

Co-authored-by: ram vikram singh <ramvikrams243@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 10, 2022
@ramvikrams @miss-islington
pythongh-100049: fix repr for mappingproxy in dictionary view exa…
76b99f5 
…mple doc (pythonGH-100052)

(cherry picked from commit 7c0fb71)

Co-authored-by: ram vikram singh <ramvikrams243@gmail.com>
@ramvikrams
Copy link
Contributor Author

ramvikrams commented Dec 10, 2022

Thanks

Thank you

miss-islington added a commit that referenced this pull request Dec 10, 2022
@miss-islington @ramvikrams
gh-100049: fix repr for mappingproxy in dictionary view example d…
9aca003 
…oc (GH-100052)

(cherry picked from commit 7c0fb71)

Co-authored-by: ram vikram singh <ramvikrams243@gmail.com>
miss-islington added a commit that referenced this pull request Dec 10, 2022
@miss-islington @ramvikrams
gh-100049: fix repr for mappingproxy in dictionary view example d…
92dd53b 
…oc (GH-100052)

(cherry picked from commit 7c0fb71)

Co-authored-by: ram vikram singh <ramvikrams243@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ramvikrams @eklunko @miss-islington @kumaraditya303 @bedevere-bot
X Tutup