gh-90016: Deprecate default sqlite3 adapters and converters #94276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc. @iafisher: would you mind reviewing this? |
iafisher
reviewed
Jun 25, 2022
erlend-aasland
commented
Jun 26, 2022
CAM-Gerlach
reviewed
Jun 29, 2022
Thanks @erlend-aasland , and sorry for the delay! Just a handful of textual and reST/Sphinx fixes/suggestions.
Misc/NEWS.d/next/Library/2022-06-25-23-44-44.gh-issue-90016.EB409s.rst
Outdated
Show resolved
Hide resolved
|
Reviews addressed in d3dd3b4 |
CAM-Gerlach
approved these changes
Jul 2, 2022
Misc/NEWS.d/next/Library/2022-06-25-23-44-44.gh-issue-90016.EB409s.rst
Outdated
Show resolved
Hide resolved
…409s.rst Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
|
@felixxm, I guess this change is ok with Django; AFAIK, you use your own adapters/converters? @serhiy-storchaka and @malemburg, would you two mind reviewing this? |
Yes, it works for us |
|
I'll resolve the conflicts and land this PR later tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Closes gh-90016