test: add fix so that test exits if port 42 is unprivileged #45904
+12
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
|
The way the test is written now makes it possible for future regressions to go undetected so that's no good, unfortunately. I'd simply call out to sysctl(1) with execSync() to check the value. There's at least one other instance of that in our test suite so it's not without precedent. |
|
Okay, I'll make these changes |
|
@bnoordhuis is this fine? |
bnoordhuis
reviewed
Dec 19, 2022
|
added these changes @bnoordhuis |
|
Can you try merging again? Had some lint errors, hopefully, they are fixed now. @bnoordhuis |
bnoordhuis
reviewed
Dec 21, 2022
|
Can you please take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
fixes: #45838