X Tutup
The Wayback Machine - https://web.archive.org/web/20221214075420/https://github.com/python/cpython/pull/100209
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that zipfile's pwd parameter is a bytes object #100209

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JustAnotherArchivist
Copy link
Contributor

@JustAnotherArchivist JustAnotherArchivist commented Dec 13, 2022

Trivial docs change for which no issue exists.

This has been a requirement for a very long time (the exception on using non-bytes was added before 2.7; I didn't search beyond that) but was never documented anywhere as far as I can see.

Needs backports to earlier branches.

@netlify
Copy link

netlify bot commented Dec 13, 2022

Deploy Preview for python-cpython-preview ready!

Name Link
🔨 Latest commit 81b6e1a
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/6398236f8640a20009af66fd
😎 Deploy Preview https://deploy-preview-100209--python-cpython-preview.netlify.app/library/zipfile
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Dec 13, 2022
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Thanks, this looks good to me. I confirmed that pwd does seem to need to be bytes and not e.g. bytearray or a buffer.

Doc/library/zipfile.rst Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting core review docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants
X Tutup