X Tutup
The Wayback Machine - https://web.archive.org/web/20221201061348/https://github.com/nodejs/node/pull/45556
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add version description about fsPromise.constants #45556

Merged
merged 1 commit into from Nov 21, 2022
Merged

doc: add version description about fsPromise.constants #45556

merged 1 commit into from Nov 21, 2022
+6 −0

Conversation

lvqq
Copy link
Contributor

@lvqq lvqq commented Nov 21, 2022 •
edited by aduh95

Add version description about fsPromise.constants in doc.

Refs: #43177

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Nov 21, 2022
@anonrig anonrig changed the title docs: add version description about fsPromise.constants doc: add version description about fsPromise.constants Nov 21, 2022
@lvqq lvqq requested a review from anonrig Nov 21, 2022
lpinca
lpinca approved these changes Nov 21, 2022
View changes
@lpinca lpinca added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2022

Fast-track has been requested by @lpinca. Please 👍 to approve.

@aduh95 aduh95 added dont-land-on-v14.x PRs that should not land on the v14.x-staging branch and should not be released in v14.x. commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Nov 21, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 21, 2022
@nodejs-github-bot nodejs-github-bot merged commit 07e2ad3 into nodejs:main Nov 21, 2022
21 checks passed
@nodejs-github-bot
Copy link
Contributor

nodejs-github-bot commented Nov 21, 2022

Landed in 07e2ad3

marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@lvqq @marco-ippolito
doc: add version description about fsPromise.constants
377f75f 
PR-URL: nodejs#45556
Refs: nodejs#43177
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ruyadorno pushed a commit that referenced this pull request Nov 24, 2022
@lvqq @ruyadorno
doc: add version description about fsPromise.constants
4345732 
PR-URL: #45556
Refs: #43177
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca

@anonrig anonrig

@cjihrig cjihrig

@RaisinTen RaisinTen

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. dont-land-on-v14.x PRs that should not land on the v14.x-staging branch and should not be released in v14.x. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@lvqq @nodejs-github-bot @lpinca @anonrig @cjihrig @RaisinTen @aduh95
X Tutup