doc: mark ECMAScript modules implementation as stable #35781

guybedford · 2020-10-23T18:51:49Z

Per discussion at the last meeting this is a PR to mark the entire ECMAScript modules implementation as stable while keeping the individual subfeatures unstable as appropriate.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2020-10-23T18:51:53Z

Review requested:

@nodejs/modules

MylesBorins

As mentioned in the meeting I would like to see the commonjs named exports bake a bit longer before landing this.

Thoughts?

doc/api/esm.md

guybedford · 2020-10-23T19:48:25Z

My main reason for posting this now was that it would be nice to include in the 12 backport process, since the two milestones here go together in my mind.

guybedford · 2020-10-23T19:49:43Z

I'm totally fine with delaying this explicit "announcement" though too. It would be good to define what we mean by settled as well.

doc/api/esm.md

mcollina

lgtm

benjamingr

Good job @nodejs/modules-active-members !!!

I know this was a long and hard journey.

MylesBorins

Marking request changes to make it explicit that I want to see CJS named export detection bake in a release more before we flip the bit to mark this stable.

I'd like to see at least another 3 - 4 weeks.

MylesBorins · 2020-11-09T23:04:29Z

We have the latest implementation slated to land in 12.20.0 on Novmber 24th. How do folks feel about calling the implementation stable for that date?

targos · 2020-11-10T05:51:14Z

What about v14.x?

MylesBorins · 2020-11-10T06:01:08Z

@targos I feel like we can mark stable on 14.x in the next semver minor. Thoughts?

targos · 2020-11-10T06:04:56Z

Yes, but I think it would be nice to schedule it close to the v12.x release. Imo it would be very confusing if v12 had more advanced features than v14 during multiple months

guybedford · 2020-11-10T16:54:30Z

For 14.x do we need to wait for semver minor? Since the implementation is already in place there it could just be like an unflagging.

MylesBorins · 2020-11-10T21:46:22Z

we can land the updates without marking stale.

MylesBorins · 2020-11-18T20:27:13Z

It dawned on me that we might want this stabilization to go out next week. As such I've gone ahead and approved this PR, so it can get picked up in next weeks release. Since there are no objection to landing by anyone else I'll go ahead and land this momentarily.

After many years of work we are marking ESM in Node.js as stable and sunsetting the Modules Team. Some high level next steps * Mark modules as stable in core * Review remaining open issues in nodejs/modules and close / transfer * Simplify team structure and prune inactive team members Refs: nodejs/node#35781 Refs: nodejs/modules#567 Refs: https://github.com/orgs/nodejs/teams/modules/discussions/8

PR-URL: #35781 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>

MylesBorins · 2020-11-18T22:43:05Z

Landed in 73ea670

watilde · 2020-11-19T08:30:01Z

Great job! 🚀

@guybedford you might want to delete the branch from upstream repository

mreinstein · 2020-11-19T17:02:15Z

Thank you thank you thank you thank you!

PR-URL: #35781 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>

* strategic initiatives: mark modules as complete After many years of work we are marking ESM in Node.js as stable and sunsetting the Modules Team. Some high level next steps * Mark modules as stable in core * Review remaining open issues in nodejs/modules and close / transfer * Simplify team structure and prune inactive team members Refs: nodejs/node#35781 Refs: nodejs/modules#567 Refs: https://github.com/orgs/nodejs/teams/modules/discussions/8

PR-URL: #35781 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>

PR-URL: nodejs#35781 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>

PR-URL: nodejs#35781 Backport-PR-URL: nodejs#37718 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>

PR-URL: nodejs#35781 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>

PR-URL: #35781 Backport-PR-URL: #37719 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>

nodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels Oct 23, 2020

guybedford changed the title ~~doc: mark modules implementation as stable~~ doc: mark ECMAScript modules implementation as stable Oct 23, 2020

MylesBorins reviewed Oct 23, 2020

View changes

doc/api/esm.md Outdated Show resolved Hide resolved

aduh95 reviewed Oct 23, 2020

View changes

doc/api/esm.md Outdated Show resolved Hide resolved

mcollina approved these changes Oct 24, 2020

View changes

benjamingr approved these changes Oct 24, 2020

View changes

Trott approved these changes Oct 24, 2020

View changes

targos approved these changes Oct 24, 2020

View changes

fhinkel approved these changes Oct 26, 2020

View changes

jasnell approved these changes Oct 26, 2020

View changes

MylesBorins requested changes Oct 26, 2020

View changes

aduh95 approved these changes Nov 9, 2020

View changes

guybedford force-pushed the stabilize-modules branch from 3612dcb to 49a3d17 Compare Nov 15, 2020

MylesBorins approved these changes Nov 18, 2020

View changes

doc: mark modules implementation as stable

b4758ff

MylesBorins force-pushed the stabilize-modules branch from 49a3d17 to b4758ff Compare Nov 18, 2020

MylesBorins mentioned this pull request Nov 18, 2020

strategic initiatives: mark modules as complete nodejs/TSC#953

Merged

DerekNonGeneric approved these changes Nov 18, 2020

View changes

MylesBorins closed this Nov 18, 2020

guybedford deleted the stabilize-modules branch Nov 19, 2020

codebytere mentioned this pull request Nov 22, 2020

v15.3.0 proposal #36232

Merged

MylesBorins added the baking-for-lts PRs that need to wait before landing in a LTS release. label Nov 24, 2020

MylesBorins mentioned this pull request Nov 24, 2020

doc: stabilize subpath patterns #36177

Closed

3 tasks

saschanaz mentioned this pull request Nov 29, 2020

Sunset UMD support w3c/webidl2.js#514

Closed

aduh95 mentioned this pull request Feb 14, 2021

Discuss: Should Highlight.js version 11 npm release be ESM only? highlightjs/highlight.js#2600

Closed

This was referenced Mar 11, 2021

[v12.x] doc: mark modules implementation as stable #37718

Merged

[v14.x] doc: mark modules implementation as stable #37719

Closed

richardlau mentioned this pull request Mar 18, 2021

v12.22.0 proposal #37797

Merged

aduh95 mentioned this pull request Mar 21, 2021

import(cjs) with query strings has odd behavior #29812

Closed

remcohaszing mentioned this pull request Apr 19, 2021

Convert to ESM only JedWatson/classnames#238

Closed

targos added backported-to-v14.x PRs backported to the v14.x-staging branch. and removed baking-for-lts PRs that need to wait before landing in a LTS release. labels Apr 25, 2021

danielleadams mentioned this pull request May 3, 2021

v14.17.0 proposal #38507

Merged

viceice mentioned this pull request May 6, 2021

Migrate from cjs to esm renovatebot/renovate#9890

Open

aduh95 mentioned this pull request Jan 22, 2022

doc: fix documentation for MODULE_NOT_FOUND and ERR_MODULE_NOT_FOUND #41645

Merged

doc: mark ECMAScript modules implementation as stable #35781

doc: mark ECMAScript modules implementation as stable #35781

guybedford commented Oct 23, 2020 •

edited

nodejs-github-bot commented Oct 23, 2020

MylesBorins left a comment

guybedford commented Oct 23, 2020

guybedford commented Oct 23, 2020

mcollina left a comment

benjamingr left a comment

MylesBorins left a comment

MylesBorins commented Nov 9, 2020

targos commented Nov 10, 2020

MylesBorins commented Nov 10, 2020

targos commented Nov 10, 2020

guybedford commented Nov 10, 2020

MylesBorins commented Nov 10, 2020

MylesBorins commented Nov 18, 2020

MylesBorins commented Nov 18, 2020

watilde commented Nov 19, 2020

mreinstein commented Nov 19, 2020

doc: mark ECMAScript modules implementation as stable #35781

doc: mark ECMAScript modules implementation as stable #35781

Conversation

guybedford commented Oct 23, 2020 • edited

Checklist

nodejs-github-bot commented Oct 23, 2020

MylesBorins left a comment

guybedford commented Oct 23, 2020

guybedford commented Oct 23, 2020

mcollina left a comment

benjamingr left a comment

MylesBorins left a comment

MylesBorins commented Nov 9, 2020

targos commented Nov 10, 2020

MylesBorins commented Nov 10, 2020

targos commented Nov 10, 2020

guybedford commented Nov 10, 2020

MylesBorins commented Nov 10, 2020

MylesBorins commented Nov 18, 2020

MylesBorins commented Nov 18, 2020

watilde commented Nov 19, 2020

mreinstein commented Nov 19, 2020

guybedford commented Oct 23, 2020 •

edited