X Tutup
The Wayback Machine - https://web.archive.org/web/20221207034327/https://github.com/python/cpython/pull/99971
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-99970 Adding a missing parameter in the documentation of doctest #99971

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-99970 Adding a missing parameter in the documentation of doctest #99971

wants to merge 1 commit into from
+1 −1

Conversation

busywhitespace
Copy link
Contributor

@busywhitespace busywhitespace commented Dec 3, 2022 •
edited by bedevere-bot

Adding optionflags parameter into the signature of DocTestSuite function.

See #99970 for more details.

@bedevere-bot bedevere-bot mentioned this pull request Dec 3, 2022
Open
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Dec 3, 2022
sobolevn
sobolevn approved these changes Dec 4, 2022
View changes
Copy link
Member

@sobolevn sobolevn left a comment

Thank you! LGTM.

Docstring of DocTestSuite indeed has it:

cpython/Lib/doctest.py

Lines 2389 to 2390 in bf26bdf

optionflags
A set of doctest option flags expressed as an integer.

And **options passed to DocTestCase does not have any extra kwargs:

cpython/Lib/doctest.py

Lines 2172 to 2173 in bf26bdf

def __init__(self, test, optionflags=0, setUp=None, tearDown=None,
checker=None):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn

Assignees
No one assigned
Labels
awaiting core review docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@busywhitespace @sobolevn @bedevere-bot
X Tutup