Added the solution of Min Stack in Python #7833
Conversation
Added the solution of Min Stack in Python.
Added the solution of the problem Min Stack in Python
algorithms-keeper
bot
added
require tests
![algorithms-keeper[bot]](https://web.archive.org/web/20250522160317im_/https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| # Name: Ritika Rastogi | ||
| # Date: 27-10-2022 | ||
| class MinStack(object): | ||
| def __init__(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
| def __init__(self): | ||
| self.object = [] | ||
|
|
||
| def push(self, val): |
There was a problem hiding this comment.
Please provide return type hint for the function: push. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/stacks/min_stack.py, please provide doctest for the function push
Please provide type hint for the parameter: val
| self.val = val | ||
| self.object.append(val) | ||
|
|
||
| def pop(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: pop. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/stacks/min_stack.py, please provide doctest for the function pop
| """ | ||
| return self.object.pop() | ||
|
|
||
| def top(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: top. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/stacks/min_stack.py, please provide doctest for the function top
| """ | ||
| return self.object[-1] | ||
|
|
||
| def getMin(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: getMin. If the function does not return a value, please provide the type hint as: def function() -> None:
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: getMin
As there is no test file in this pull request nor any test function or class in the file data_structures/stacks/min_stack.py, please provide doctest for the function getMin
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| # Name: Ritika Rastogi | ||
| # Date: 27-10-2022 | ||
| class MinStack: | ||
| def __init__(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
| def __init__(self): | ||
| self.object = [] | ||
|
|
||
| def push(self, val): |
There was a problem hiding this comment.
Please provide return type hint for the function: push. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/stacks/min_stack.py, please provide doctest for the function push
Please provide type hint for the parameter: val
| self.val = val | ||
| self.object.append(val) | ||
|
|
||
| def pop(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: pop. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/stacks/min_stack.py, please provide doctest for the function pop
| """ | ||
| return self.object.pop() | ||
|
|
||
| def top(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: top. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/stacks/min_stack.py, please provide doctest for the function top
| """ | ||
| return self.object[-1] | ||
|
|
||
| def getMin(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: getMin. If the function does not return a value, please provide the type hint as: def function() -> None:
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: getMin
As there is no test file in this pull request nor any test function or class in the file data_structures/stacks/min_stack.py, please provide doctest for the function getMin
cclauss
added
ON HOLD: Final hours of Hacktoberfest
There was a problem hiding this comment.
- I assume you got this problem from a site like LeetCode, which clearly defines a Min Stack to have an
$O(1)$ minfunction. However, yourminfunction is$O(n)$ , so this is just a regular stack with aminfunction, not a Min Stack. - Speaking of regular stacks, we already have a stack implementation in data_structures/stacks/stack.py that is more comprehensive than the one here.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.