X Tutup
The Wayback Machine - https://web.archive.org/web/20210814023018/https://github.com/nodejs/node/pull/37974
Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix typo for initialization #37974

Closed
wants to merge 1 commit into from
Closed

src: fix typo for initialization #37974

wants to merge 1 commit into from

Conversation

@yashLadha
Copy link
Contributor

@yashLadha yashLadha commented Mar 30, 2021

No description provided.

@yashLadha
src: fix typo for initialization
4cd7375
@cjihrig
cjihrig approved these changes Mar 30, 2021
View changes
@marsonya
marsonya approved these changes Mar 30, 2021
View changes
@addaleax
addaleax approved these changes Mar 30, 2021
View changes
@RaisinTen
RaisinTen approved these changes Mar 30, 2021
View changes
@Trott
Trott approved these changes Apr 2, 2021
View changes
@PoojaDurgad
PoojaDurgad approved these changes Apr 5, 2021
View changes
@jasnell
jasnell approved these changes Apr 6, 2021
View changes
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@jasnell jasnell removed the needs-ci label Apr 7, 2021
@nodejs-github-bot
Copy link

@nodejs-github-bot nodejs-github-bot commented Apr 7, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/37255/
@yashLadha
Copy link
Contributor Author

@yashLadha yashLadha commented Apr 8, 2021

Should I go ahead and deploy, it doesn't seem that big of a change @jasnell 😅 and is open for quite some time.
@jasnell
Copy link
Member

@jasnell jasnell commented Apr 8, 2021

We have to get a good ci run first. It's irritating that ci has been so flaky but it's gotta be yellow or green before this can land
@nodejs-github-bot
Copy link

@nodejs-github-bot nodejs-github-bot commented Apr 8, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/37294/
RaisinTen added a commit that referenced this pull request Apr 8, 2021
@yashLadha @RaisinTen
src: fix typo for initialization
8d63aa8 
PR-URL: #37974
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RaisinTen
Copy link
Member

@RaisinTen RaisinTen commented Apr 8, 2021

Landed in 8d63aa8
@RaisinTen RaisinTen closed this Apr 8, 2021
@BethGriggs BethGriggs mentioned this pull request Apr 12, 2021
Merged
targos added a commit that referenced this pull request May 1, 2021
@yashLadha @targos
src: fix typo for initialization
854a2a9 
PR-URL: #37974
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@Trott Trott

@addaleax addaleax

@cjihrig cjihrig

@marsonya marsonya

@RaisinTen RaisinTen

@PoojaDurgad PoojaDurgad

Assignees
No one assigned
Labels
author ready c++
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants
@yashLadha @nodejs-github-bot @jasnell @RaisinTen @Trott @addaleax @cjihrig @marsonya @PoojaDurgad
X Tutup