X Tutup
The Wayback Machine - https://web.archive.org/web/20220423233525/https://github.com/nodejs/node/pull/37633
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove FLAKY status for fixed test #37633

Merged
merged 1 commit into from Mar 8, 2021
Merged

test: remove FLAKY status for fixed test #37633

merged 1 commit into from Mar 8, 2021

Conversation

Copy link
Member

@Trott Trott commented Mar 6, 2021

test-worker-message-port-transfer-terminate was fixed in
25447d8 but the status file was not updated to reflect this.

@nodejs-github-bot nodejs-github-bot added needs-ci test labels Mar 6, 2021
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Mar 6, 2021

@PoojaDurgad PoojaDurgad added the author ready label Mar 8, 2021
test-worker-message-port-transfer-terminate was fixed in
25447d8 but the status file was not updated to reflect this.

PR-URL: nodejs#37633
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott
Copy link
Member Author

@Trott Trott commented Mar 8, 2021

Landed in 5cea29b

@Trott Trott merged commit 5cea29b into nodejs:master Mar 8, 2021
9 of 11 checks passed
@Trott Trott deleted the status-only branch Mar 8, 2021
danielleadams pushed a commit that referenced this issue Mar 16, 2021
test-worker-message-port-transfer-terminate was fixed in
25447d8 but the status file was not updated to reflect this.

PR-URL: #37633
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this issue May 1, 2021
test-worker-message-port-transfer-terminate was fixed in
25447d8 but the status file was not updated to reflect this.

PR-URL: #37633
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready needs-ci test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants
X Tutup