X Tutup
The Wayback Machine - https://web.archive.org/web/20220323062153/https://github.com/nodejs/node/pull/37312
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix typo in /api/dns.md #37312

Merged
merged 1 commit into from Feb 13, 2021
Merged

doc: fix typo in /api/dns.md #37312

merged 1 commit into from Feb 13, 2021

Conversation

marsonya
Copy link
Member

@marsonya marsonya commented Feb 10, 2021

In doc/api/dns.md
'critical' spelled 'critial' (twice)

@nodejs-github-bot nodejs-github-bot added dns doc labels Feb 10, 2021
lpinca
lpinca approved these changes Feb 10, 2021
Trott
Trott approved these changes Feb 10, 2021
Copy link

@ItzLevvie ItzLevvie left a comment

LGTM.

Lxxyx
Lxxyx approved these changes Feb 11, 2021
@PoojaDurgad PoojaDurgad added the author ready label Feb 11, 2021
PR-URL: #37312
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@aduh95 aduh95 merged commit e511c0b into nodejs:master Feb 13, 2021
13 checks passed
@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 13, 2021

Landed in e511c0b

danielleadams added a commit that referenced this issue Feb 16, 2021
PR-URL: #37312
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 16, 2021
@danielleadams danielleadams mentioned this pull request Feb 16, 2021
targos added a commit that referenced this issue May 1, 2021
PR-URL: #37312
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready dns doc
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

X Tutup