benchmark: fix http/headers.js with test-double #36794
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
benchmark
aduh95
approved these changes
Jan 5, 2021
juanarbol
approved these changes
Jan 5, 2021
github-actions
bot
removed
the
request-ci
antsmartian
approved these changes
Jan 7, 2021
The http/headers.js benchmark fails if wrk or autocannon are not installed. This is because the benchmark exceeds the default permissible length for HTTP headers. Reduce the largest benchmarks to fit within the 8192 default as that is what we should be optimizing for. Fixes: nodejs#31022 PR-URL: nodejs#36794 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
|
Landed in 1e35d58 |
danielleadams
pushed a commit
that referenced
this issue
Jan 12, 2021
The http/headers.js benchmark fails if wrk or autocannon are not installed. This is because the benchmark exceeds the default permissible length for HTTP headers. Reduce the largest benchmarks to fit within the 8192 default as that is what we should be optimizing for. Fixes: #31022 PR-URL: #36794 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Merged
targos
pushed a commit
that referenced
this issue
May 1, 2021
The http/headers.js benchmark fails if wrk or autocannon are not installed. This is because the benchmark exceeds the default permissible length for HTTP headers. Reduce the largest benchmarks to fit within the 8192 default as that is what we should be optimizing for. Fixes: #31022 PR-URL: #36794 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The http/headers.js benchmark fails if wrk or autocannon are not
installed. This is because the benchmark exceeds the default permissible
length for HTTP headers. Reduce the largest benchmarks to fit within the
8192 default as that is what we should be optimizing for.
Fixes: #31022