lib: remove dead code from internal/http.js #36630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamingr
approved these changes
Dec 25, 2020
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Dec 25, 2020
aduh95
added
the
author ready
addaleax
approved these changes
Dec 26, 2020
Trott
approved these changes
Dec 27, 2020
PR-URL: nodejs#36630 Refs: nodejs#32329 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott
force-pushed
the
remove-internal-http-deadcode
branch
from
8cf00b9
to
acaa58e
Compare
|
Landed in acaa58e |
Merged
aduh95
pushed a commit
to aduh95/node
that referenced
this issue
Jan 13, 2021
PR-URL: nodejs#36630 Refs: nodejs#32329 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The
nowDatefunction is no longer used, but the code is not removed.Refs: #32329
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes