X Tutup
The Wayback Machine - https://web.archive.org/web/20230218233911/https://github.com/nodejs/node/pull/36102
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix unreliable test-fs-write-file.js #36102

Merged
merged 1 commit into from Nov 12, 2020
Merged

test: fix unreliable test-fs-write-file.js #36102

merged 1 commit into from Nov 12, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 12, 2020

The test uses a file name twice, causing unreliability in CI. In
particular, it's failing a lot on the Raspberry Pi devices.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 12, 2020
@Trott Trott mentioned this pull request Nov 12, 2020
Closed
@Trott
Copy link
Member Author

Trott commented Nov 12, 2020

Fast track?

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Trott Trott added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Nov 12, 2020
lpinca
lpinca approved these changes Nov 12, 2020
View changes
@nodejs-github-bot
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/34377/

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 12, 2020
@Trott
test: fix unreliable test-fs-write-file.js
f03f7cb 
The test uses a file name twice, causing unreliability in CI. In
particular, it's failing a lot on the Raspberry Pi devices.

Fixes: nodejs#36090

PR-URL: nodejs#36102
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@Trott Trott merged commit f03f7cb into nodejs:master Nov 12, 2020
@Trott
Copy link
Member Author

Trott commented Nov 12, 2020

Landed in f03f7cb

@Trott Trott deleted the fix-broken-test branch November 12, 2020 23:08
@BethGriggs BethGriggs added the dont-land-on-v14.x PRs that should not land on the v14.x-staging branch and should not be released in v14.x. label Dec 7, 2020
@Linkgoron Linkgoron mentioned this pull request Apr 29, 2021
Closed
@targos targos added backport-open-v14.x Indicate that the PR has an open backport. and removed dont-land-on-v14.x PRs that should not land on the v14.x-staging branch and should not be released in v14.x. labels Apr 30, 2021
targos pushed a commit to targos/node that referenced this pull request Apr 30, 2021
@Trott @targos
test: fix unreliable test-fs-write-file.js
9abc11a 
The test uses a file name twice, causing unreliability in CI. In
particular, it's failing a lot on the Raspberry Pi devices.

Fixes: nodejs#36090

PR-URL: nodejs#36102
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos pushed a commit that referenced this pull request Apr 30, 2021
@Trott @targos
test: fix unreliable test-fs-write-file.js
de654bf 
The test uses a file name twice, causing unreliability in CI. In
particular, it's failing a lot on the Raspberry Pi devices.

Fixes: #36090

PR-URL: #36102
Backport-PR-URL: #38386
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos targos added backported-to-v14.x PRs backported to the v14.x-staging branch. and removed backport-open-v14.x Indicate that the PR has an open backport. labels Apr 30, 2021
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca

@richardlau richardlau

Assignees
No one assigned
Labels
backported-to-v14.x PRs backported to the v14.x-staging branch. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Trott @nodejs-github-bot @lpinca @richardlau @targos @BethGriggs
X Tutup