X Tutup
The Wayback Machine - https://web.archive.org/web/20220323030017/https://github.com/nodejs/node/pull/36089
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve test coverage SourceMap API #36089

Merged
merged 0 commits into from Nov 24, 2020
Merged

test: improve test coverage SourceMap API #36089

merged 0 commits into from Nov 24, 2020

Conversation

juanarbol
Copy link
Member

@juanarbol juanarbol commented Nov 11, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test label Nov 11, 2020
Trott
Trott approved these changes Nov 12, 2020
View changes
@Trott Trott added the request-ci label Nov 14, 2020
@github-actions github-actions bot removed the request-ci label Nov 14, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Nov 14, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/34392/

@juanarbol juanarbol added the request-ci label Nov 23, 2020
@github-actions github-actions bot removed the request-ci label Nov 23, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Nov 23, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/34512/

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Nov 23, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/34516/

@Trott
Copy link
Member

@Trott Trott commented Nov 24, 2020

Landed in 68795f9

@Trott Trott closed this Nov 24, 2020
@Trott Trott force-pushed the juanarbol/improve-sourcemaps-coverage branch from aae4bbe to 68795f9 Compare Nov 24, 2020
@Trott Trott merged commit 68795f9 into nodejs:master Nov 24, 2020
10 checks passed
danielleadams added a commit that referenced this issue Dec 7, 2020
@juanarbol @danielleadams
test: improve test coverage SourceMap API
69a8f05 
PR-URL: #36089
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
Merged
@juanarbol juanarbol deleted the juanarbol/improve-sourcemaps-coverage branch Jan 19, 2021
targos added a commit that referenced this issue May 1, 2021
@juanarbol @targos
test: improve test coverage SourceMap API
94a877b 
PR-URL: #36089
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott

@Himself65 Himself65

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
4 participants
@juanarbol @nodejs-github-bot @Trott @Himself65
X Tutup